Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky aria-disabled tests #621

Merged
merged 2 commits into from
Nov 9, 2023
+3 −3
Merged

Fix flaky aria-disabled tests #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678cb78
Fix flaky aria-disabled tests
josiasds Nov 9, 2023
1bea6d7
Version bump: 9.2.2
lpluser Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpadlab/lp-components",
"version": "9.2.1",
"version": "9.2.2",
"engines": {
"node": "^18.12"
},
Expand Down
4 changes: 2 additions & 2 deletions test/forms/buttons/button.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ test('Button is aria-disabled when form is invalid', () => {
render(<Button invalid={true}>Hi</Button>)
const button = screen.getByRole('button')

expect(button).toHaveAttribute('aria-disabled')
expect(button).toHaveAttribute('aria-disabled', 'true')
})

test('Button is aria-disabled when form is pristine', () => {
render(<Button pristine={true}>Hi</Button>)
const button = screen.getByRole('button')

expect(button).toHaveAttribute('aria-disabled')
expect(button).toHaveAttribute('aria-disabled', 'true')
})

test('Button onClick is run when the form is not submitting, pristine, or invalid', async () => {
Expand Down