Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky aria-disabled tests #621

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

josiasds
Copy link
Contributor

@josiasds josiasds commented Nov 9, 2023

@chawes13 found a flaky test when reviewing the RTL Cheat Sheet.

We were only checking for the existence of the aria-disabled attribute but not its value. If aria-disabled were false, the test would still pass, and that's not the desired outcome.

Release Notes

Author Checklist

  • Add unit test(s)
  • Update version in package.json (see the versioning guidelines)
  • Update documentation (if necessary)
  • Add story to storybook (if necessary)
  • Assign dev reviewer

@josiasds josiasds requested a review from chawes13 November 9, 2023 03:05
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this too! You beat me to it. Thanks a bunch 🙏

@chawes13 chawes13 merged commit a4628a3 into main Nov 9, 2023
2 checks passed
@chawes13 chawes13 deleted the chore/fix-aria-disabled-expectation branch November 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants