Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs improviments (Storm integration) #12

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Docs improviments (Storm integration) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion contrib/demo-rgb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,14 @@ rgb psbt analyze ${PSBT}
# referencing this txid.
# We also instruct the daemon to send the consignment to the beneficiary LN node.
# If done on the same system (a self-payment), the --send argument can be omitted.
rgb-cli -n testnet transfer finalize --endseal ${TXOB} ${PSBT} ${CONSIGNMENT} --send
# If done on the remote peer, the --send argument is reqquired.
# For sending to the remote peer, we need to check if both peers (self and remote)
# have connected by Bifrost protocol (check this using `lnp-cli peers` method).
NODE_ID="..." #The node_id of the beneficiary LN node
STORM_ADDR="..." #The stormd IP connected in your RGB node
STORM_PORT="..." #The stormd RPC port
Comment on lines +148 to +150
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these used anywhere? If yes, I think ppl will struggle to repeat the demo in this way; we first need to add *-cli commands which would return the node ids, and than put here stuff like *_ID=`*-cli node-id`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

I will make the changes.

BENEFICIARY="$NODE_ID@$STORM_ADDR:$STORM_PORT"
rgb-cli -n testnet transfer finalize --endseal ${TXOB} ${PSBT} ${CONSIGNMENT} --send $BENEFICIARY

# Those who interested can look into the transfer consignment
rgb consignment inspect ${CONSIGNMENT}
Expand Down