Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improviments (Storm integration) #12

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Docs improviments (Storm integration) #12

merged 1 commit into from
Dec 27, 2022

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Sep 14, 2022

Description

After making tests and fixies the integration between rgb-node and storm-node, I decided to add information about storm integration works.

Related Issues

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we need to get all PRs listed in the description to be merged before merging this one?
  2. Pls check my review comment

Comment on lines +148 to +150
NODE_ID="..." #The node_id of the beneficiary LN node
STORM_ADDR="..." #The stormd IP connected in your RGB node
STORM_PORT="..." #The stormd RPC port
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these used anywhere? If yes, I think ppl will struggle to repeat the demo in this way; we first need to add *-cli commands which would return the node ids, and than put here stuff like *_ID=`*-cli node-id`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

I will make the changes.

@crisdut
Copy link
Member Author

crisdut commented Sep 18, 2022

  1. Do we need to get all PRs listed in the description to be merged before merging this one?

Yes, I could transfer the consignment file only with all the fixes.

  1. Pls check my review comment

Sure.

@dr-orlovsky dr-orlovsky merged commit 2f47683 into LNP-BP:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants