Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the setup dialog #3820

Merged
merged 57 commits into from
Sep 6, 2019
Merged

Rewrite the setup dialog #3820

merged 57 commits into from
Sep 6, 2019

Conversation

Sawuare
Copy link
Member

@Sawuare Sawuare commented Sep 23, 2017

General
Performance
Audio
MIDI
Paths

Changes:

This slightly modifies ConfigManager and its related files.

• Enhanced code quality and style.
• Commented some code.
• Improved translatable strings.
• Improved GUI and fixed minor GUI bugs.
• Improved the look for plugins embedding settings. 1c9ff9a
• Divided the MISC tab into 2 tabs: GUI and Projects, and moved some of its items.
• Moved some items to more appropriate sections.
• Changed the restart warning from a QMessageBox to a QLabel that is shown when a setting that requires restarting is changed.
• Removed the useless context help button. 8689e51

Closes #3681.

@lukas-w
Copy link
Member

lukas-w commented Sep 23, 2017

Screenshots by @Sawuare from Discord:

Edited, @Sawuare, removed the screenshots because they're out-of-date. Up-to-date screenshots are in the issue's description.

@Umcaruje Umcaruje added this to the 1.3.0 milestone Oct 2, 2017
include/ConfigManager.h Show resolved Hide resolved
@Sawuare Sawuare changed the title Setup dialog improvements. (Clean) Setup dialog improvements. Nov 4, 2017
@michaelgregorius
Copy link
Contributor

Don't know if this was already addressed in one of the commits but I wouldn't keep the option "Display restart warning after changing settings" where it is shown here:

image

Perhaps it can be moved into the GUI section because it affects the GUI behavior.

@tresf
Copy link
Member

tresf commented Nov 16, 2017

That pop-up needs to be abolished. We should reuse that same area to show a warning as soon as an item is clicked.

@Sawuare
Copy link
Member Author

Sawuare commented Nov 17, 2017

That pop-up needs to be abolished. We should reuse that same area to show a warning as soon as an item is clicked.

@tresf So you agree with the first comment in #3681?
If so, should that be done in this PR?

@tresf
Copy link
Member

tresf commented Nov 17, 2017

Yes, in principle, I agree.
This PR would be a good home.

@Sawuare
Copy link
Member Author

Sawuare commented Dec 1, 2017

I want the restartWarning label (see ded1765) to show when a setting that requires restarting is changed and hide when it's at its default (last saved) value, but I don't know how to implement that.
I already have a list of changes that require restarting and changes that don't.

Any help is appreciated. :)

Sorry for referencing the first issue in ded1765. 😅

@Sawuare Sawuare added needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR labels Jun 13, 2019
src/gui/SetupDialog.cpp Outdated Show resolved Hide resolved
@Sawuare Sawuare requested a review from PhysSong June 20, 2019 10:02
include/SetupDialog.h Show resolved Hide resolved
src/gui/SetupDialog.cpp Outdated Show resolved Hide resolved
src/gui/SetupDialog.cpp Show resolved Hide resolved
@Reflexe
Copy link
Member

Reflexe commented Jul 20, 2019

A lot of changes are automatic and minor. That causes finding "real" changes much harder. Would it be OK if I'll modify this PR to include only major changes, without style and formatting changes?

@Sawuare
Copy link
Member Author

Sawuare commented Jul 20, 2019

@Reflexe Yes, please, but keep the order of statements as-is.

@Sawuare Sawuare removed needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR labels Jul 31, 2019
@Sawuare
Copy link
Member Author

Sawuare commented Jul 31, 2019

This PR is currently a mess with many stupid changes. I will hopefully tackle it next month and make it review-able.

Sawuare added a commit that referenced this pull request Oct 2, 2019
The regression was introduced in #3820.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
The regression was introduced in LMMS#3820.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart warning on setup dialog itself
10 participants