-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the setup dialog #3820
Rewrite the setup dialog #3820
Conversation
This reverts commit 8abe566.
That pop-up needs to be abolished. We should reuse that same area to show a warning as soon as an item is clicked. |
Yes, in principle, I agree. |
I want the Any help is appreciated. :) Sorry for referencing the first issue in ded1765. 😅 |
A lot of changes are automatic and minor. That causes finding "real" changes much harder. Would it be OK if I'll modify this PR to include only major changes, without style and formatting changes? |
@Reflexe Yes, please, but keep the order of statements as-is. |
This PR is currently a mess with many stupid changes. I will hopefully tackle it next month and make it review-able. |
The regression was introduced in #3820.
The regression was introduced in LMMS#3820.
Changes:
This slightly modifies ConfigManager and its related files.
• Enhanced code quality and style.
• Commented some code.
• Improved translatable strings.
• Improved GUI and fixed minor GUI bugs.
• Improved the look for plugins embedding settings. 1c9ff9a
• Divided the MISC tab into 2 tabs: GUI and Projects, and moved some of its items.
• Moved some items to more appropriate sections.
• Changed the restart warning from a QMessageBox to a QLabel that is shown when a setting that requires restarting is changed.
• Removed the useless context help button. 8689e51
Closes #3681.