Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit > Settings: Restart notification behaviour. #3627

Closed
mikobuntu opened this issue Jun 10, 2017 · 4 comments
Closed

Edit > Settings: Restart notification behaviour. #3627

mikobuntu opened this issue Jun 10, 2017 · 4 comments

Comments

@mikobuntu
Copy link
Contributor

mikobuntu commented Jun 10, 2017

Hi guys I think the popup window below should not be shown unless we have actually changed a setting in
Edit>Settings.
restartnotification

  • Right now the default behaviour is to show the Restart notification even if we don't click on anything in the settings window
@ghost
Copy link

ghost commented Jun 10, 2017

Yeah this should be fixed.

@tresf
Copy link
Member

tresf commented Jun 10, 2017

I vote we take it a step further and not be vague. Something like a boolean flag for notifying only when an actual restart setting was changed, then make the wording explicit.

@follower
Copy link
Contributor

Related to #2109?

@Sawuare
Copy link
Member

Sawuare commented Sep 6, 2019

I vote we take it a step further and not be vague. Something like a boolean flag for notifying only when an actual restart setting was changed, then make the wording explicit.

Implemented in #3820:
• Changed the restart warning from a QMessageBox to a QLabel that is shown when a setting that requires restarting is changed.

Closing.

@Sawuare Sawuare closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants