Fixed #3498. Show missing pixmaps in VeSTige plugin. #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-w
reviewed
Apr 28, 2017
plugins/vestige/vestige.cpp
Outdated
| @@ -259,7 +259,7 @@ void vestigeInstrument::loadFile( const QString & _file ) | |||
| TextFloat * tf = TextFloat::displayMessage( | |||
| tr( "Loading plugin" ), | |||
| tr( "Please wait while loading VST-plugin..." ), | |||
| PLUGIN_NAME::getIconPixmap( "logo", 24, 24 ), 0 ); | |||
| embed::getIconPixmap( "logo", 24, 24 ), 0 ); | |||
There was a problem hiding this comment.
I don't think this and other lines loading logo.png should change, as they're about loading the plugin's logo, not a shared resource, right?
There was a problem hiding this comment.
Right. I reverted logo changes.
tresf
pushed a commit
to tresf/lmms
that referenced
this pull request
May 10, 2017
This was referenced May 12, 2017
liushuyu
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 3, 2017
liushuyu
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 19, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
zonkmachine
reviewed
Oct 12, 2019
| @@ -534,7 +534,7 @@ VestigeInstrumentView::VestigeInstrumentView( Instrument * _instrument, | |||
| QPushButton * note_off_all_btn = new QPushButton( tr( "Turn off all " | |||
| "notes" ), this ); | |||
| note_off_all_btn->setGeometry( 20, 160, 200, 24 ); | |||
| note_off_all_btn->setIcon( embed::getIconPixmap( "state_stop" ) ); | |||
| note_off_all_btn->setIcon( embed::getIconPixmap( "stop" ) ); | |||
There was a problem hiding this comment.
This part of the fix should be in stable-1.2
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.