VeSTige preset left and right arrows are gone

[karmux]

In VeSTige instrument left and right arrows to browse presets are missing. Instead it shows something that looks like dead pixels. I remember that I was using these arrows about month ago on master branch.

This picture from Wiki shows how it used to look:

LMMS 1.2.0-rc2.144
(Linux x86_64, Qt 5.6.1, GCC 6.2.0 20161005)

[BaraMGB]

Those pixels appears if a pixmap couldn't be found.

[karmux]

@lukas-w , when I revert 9f905bc I get icons back.
After looking into it a bit I have no idea why some certain pixmaps always get missing.

[tresf]

@karmux please see this comment... #1891 (comment)

[karmux]

@tresf but vestige has no underscore in the name, nor has stepper-left.png. I can make stepper-left pixmap visible if I use it for "Show/hide GUI" button instead of zoom pixmap.

[tresf]

@karmux good call. What if you make this line match the others (such as in vibed):

vestige

BUILD_PLUGIN(vestige EMBEDDED_RESOURCES "${CMAKE_CURRENT_SOURCE_DIR}/*.png")

vibed

BUILD_PLUGIN(vibedstrings [...] EMBEDDED_RESOURCES *.png)

[tresf]

Scratch that... that won't change anything and these don't exist in that directory anyway. These appear to be shared artwork. Still hunting...

[tresf]

Ok... I think we need to replace PLUGIN_NAME:: with embed:: for shared LMMS (non-plugin) resources. @lukas-w should confirm...

[karmux]

I got all pixmaps back by replacing PLUGIN_NAME::getIconPixmap with embed::getIconPixmap in vestige.cpp only for missing pixmaps. Replacing for every pixmap made other pixmaps to disappear.

state_stop icon actually seems like missing (also on Wiki image).

[karmux]

VeSTige in #3501.

[karmux]

Fixed in #3501.