Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad button position in setup dialog, make the SetupDialog fixed size and EffectDialog resizeable #2532

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

Umcaruje
Copy link
Member

Fixes #1849

Before & After:

screenshot from 2016-01-29 16 38 42 screenshot from 2016-01-29 16 38 14

@zonkmachine
Copy link
Member

Tested - fixed. There is another thing in there that's a bit odd. If you grab the right edge of the window and expand it to the right it will follow and the OK/Cancel buttons too, but not the text entry fields. The way I see it either they follow or the frame should be fixed.
margin

@tresf
Copy link
Member

tresf commented Jan 29, 2016

If you grab the right edge of the window and expand it to the right it will follow and the OK/Cancel buttons too, but not the text entry fields.

Duplicate of #1849.

@Umcaruje Umcaruje changed the title Fix bad button position in setup dialog Fix bad button position in setup dialog, make the SetupDialog and EffectDialog not resizeable Jan 30, 2016
@Umcaruje
Copy link
Member Author

Ok, so, I decided to make the setup dialog fixed size, so we avoid the resize problems. I also did the same thing for EffectDialog. Comments welcome.

@tresf
Copy link
Member

tresf commented Jan 31, 2016

Looks good although I'm not a fan of all of the code editor auto-formatting changes as they makes the PR harder to read and can really make the cherry-pick process harder down the road.

I'd rather we fix formatting in separate PRs, personally.

@Umcaruje
Copy link
Member Author

I'd rather we fix formatting in separate PRs, personally.

Yeah, I agree, I'll see to disable it in atom and redo this PR.

@Umcaruje
Copy link
Member Author

@tresf done. Anything else that I need to change?

@Umcaruje Umcaruje changed the title Fix bad button position in setup dialog, make the SetupDialog and EffectDialog not resizeable Fix bad button position in setup dialog, make the SetupDialog fixed size and EffectDialog resizeable Feb 1, 2016
@Umcaruje
Copy link
Member Author

Umcaruje commented Feb 1, 2016

Ok, so I thought about it, and it really doesn't make sense to have the RenameDialog fixed size. So I made it resizeable:

gifrecord_2016-02-01_210334

As always, testing and comments welcome.

@@ -56,6 +57,13 @@ RenameDialog::~RenameDialog()



void RenameDialog::resizeEvent (QResizeEvent * event) {
m_stringLE->setGeometry ( 10, 5, width() - 20, 20 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note on this... I feel we shouldn't get too comfortable with the resize hacks, but rather use containers which can handle resizing properly. That said, looks *good.

tresf added a commit that referenced this pull request Feb 2, 2016
Fix bad button position in setup dialog, make the SetupDialog fixed size and EffectDialog resizeable
@tresf tresf merged commit e03eb1c into LMMS:master Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants