-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad button position in setup dialog, make the SetupDialog fixed size and EffectDialog resizeable #2532
Conversation
Duplicate of #1849. |
3b5f837
to
e5b320c
Compare
Ok, so, I decided to make the setup dialog fixed size, so we avoid the resize problems. I also did the same thing for |
Looks good although I'm not a fan of all of the code editor auto-formatting changes as they makes the PR harder to read and can really make the cherry-pick process harder down the road. I'd rather we fix formatting in separate PRs, personally. |
Yeah, I agree, I'll see to disable it in atom and redo this PR. |
e5b320c
to
f0a0f7c
Compare
@tresf done. Anything else that I need to change? |
f0a0f7c
to
50c71ac
Compare
…ize and EffectDialog resizeable
50c71ac
to
216143a
Compare
@@ -56,6 +57,13 @@ RenameDialog::~RenameDialog() | |||
|
|||
|
|||
|
|||
void RenameDialog::resizeEvent (QResizeEvent * event) { | |||
m_stringLE->setGeometry ( 10, 5, width() - 20, 20 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note on this... I feel we shouldn't get too comfortable with the resize hacks, but rather use containers which can handle resizing properly. That said, looks *good.
Fix bad button position in setup dialog, make the SetupDialog fixed size and EffectDialog resizeable
Fixes #1849
Before & After: