Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings dialog resizable but widgets do not adjust to its new size #1849

Closed
M374LX opened this issue Mar 10, 2015 · 6 comments
Closed

Settings dialog resizable but widgets do not adjust to its new size #1849

M374LX opened this issue Mar 10, 2015 · 6 comments
Assignees
Milestone

Comments

@M374LX
Copy link
Contributor

M374LX commented Mar 10, 2015

The settings dialog is resizable, but the widgets inside it do not adjust to the new size.

One possibility is to get the widgets to adjust to the new size. Other is to simply make the dialog unresizable.

@badosu
Copy link
Contributor

badosu commented Mar 10, 2015

This settings UI needs a serious rewrite, but this also requires some decisions on packaging assets and discovering plugins. If I am not mistaken @curlymorphic made some work on this area, thoughts?

@curlymorphic
Copy link
Contributor

simply make the dialog unresizable.

this would be my choice. The content of the dialog was not designed to be resized. Let me know if this is required.

There is currently some redesigning going on in #1807

@tresf
Copy link
Member

tresf commented Mar 10, 2015

I vote we make it a fixed size since we don't benefit much from a resizing of this particular dialog.

That doesn't mean I love it the way it is, I just think if we are going to rethink our dialogs, we should rethink them from a global UI consistency, functionality and cosmetic perspective.

@tresf
Copy link
Member

tresf commented Mar 10, 2015

I believe the major difference with this dialog versus others is that it is not an internal MDI window, it is a floating modal dialog. All of our floating modal dialogs seem to be resizable. (perhaps then resizinng its contents would be more consistent?)

@tresf tresf added the bug label Mar 10, 2015
@tresf tresf added this to the 1.3.0 milestone Mar 10, 2015
@tresf
Copy link
Member

tresf commented Mar 13, 2015

QDialogs affected by this bug:

  • SetupDialog
  • RenameDialog

QDialogs NOT affected by this bug (some are resizable, but contents resize to fit):

  • ExportProjectDialog
  • EffectSelectDialog
  • ControllerConnectionDialog
  • AboutDialog
  • plugins/sf2/PatchSelectionDialog
  • plugins/GigPlayer/PatchesDialog

A reoccurring pattern seems to be files created with XML UI files don't suffer this bug, likely because they were created with a tool such as QT Creator.

@tresf tresf mentioned this issue Mar 13, 2015
@tresf
Copy link
Member

tresf commented Mar 13, 2015

I found some solutions to this, but in testing, I ran across a crash in master when the ~/.lmmsrc.xml file is missing so I'm taking a break... :)

-Tres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants