Tripple-Osc Preset Cleanup

[StakeoutPunch]

Some of the 3OSC presets are redundant, not very useful, or just not the best sounding/have poor sound design.

I'm wondering if anyone would be opposed to me combing through them and tweaking/removing ones that aren't the best and adding quite a few of my own. Because I do all of my synthwork in 3OSC I have quite a few patches I'd like to see included in LMMS.

I'm set to go ahead and do this, I'm just not familiar enough with the different branches to know which one I'd need to merge to.

[tresf]

I'm set to go ahead and do this, I'm just not familiar enough with the different branches to know which one I'd need to merge to.

I think it sounds terrific. IIRC, the preset data is stored inside the projects so it shouldn't break backwards compat.

In terms of which branch, I would tend to lean to stable-1.1 since it hasn't been released yet and already has a bunch of preset work applied to it, but I'd rather @diizy makes that call, I'll defer to him.

[StakeoutPunch]

Well, I need is a green light and a branch to merge to and I'm set.

IIRC, the preset data is stored inside the projects so it shouldn't break backwards compat.

Correct! That is one of the reasons I decided to go ahead and bring this up, as I don't really have to consider how to maintain BC as it is not even relevant.

[eagles051387]

Wouldn't it be better to throw it into master and then back port the parch
to stable?
On 25 Aug 2014 07:23, "StakeoutPunch" [email protected] wrote:

Well, I need is a green light and a branch to merge to and I'm set.

IIRC, the preset data is stored inside the projects so it shouldn't break
backwards compat.

Correct! That is one of the reasons I decided to go ahead and bring this
up, as I don't really have to consider how to maintain BC as it is not even
relevant.

—
Reply to this email directly or view it on GitHub
#1099 (comment).

[diizy]

On 08/25/2014 08:28 AM, eagles051387 wrote:

Wouldn't it be better to throw it into master and then back port the
parch
to stable?

No.

[diizy]

On 08/25/2014 08:07 AM, Tres Finocchiaro wrote:

I'm set to go ahead and do this, I'm just not familiar enough with
the different branches to know which one I'd need to merge to.

I think it sounds terrific. IIRC, the preset data is stored inside the
projects so it shouldn't break backwards compat.

In terms of which branch, I would tend to lean to stable-1.1 since it
hasn't been released yet and already has a bunch of preset work
applied to it, but I'd rather @diizy https://github.com/diizy makes
that call, I'll defer to him.

Well, a couple of things before we get ahead of ourselves here.

Which presets do you want to remove and why? Is there some kind of
problem with these presets - like, that they don't work, don't produce
sound, crash the software, what? Remember that just because you think
some presets are "bad", doesn't mean they're useless. Sometimes people
want lo-fi sounds.

As for adding new presets... I see no problem as long as those presets
bring in something new that doesn't already exist in the LMMS preset
library. However. TripleOsc is a bit crowded already - why not
concentrate on creating new presets for synths that have very few (if
any) of them? We don't have any default presets for Monstro, Mallets,
Sid, Freeboy... rather than add to the already overcrowded TripleOsc,
it'd be much better to get some presets for those instruments.

[tresf]

@diizy, I don't think he's getting ahead of himself because he's just asking where to put the pull request. Isn't the pull request the place for the granular "why is this changed?" discussion?

-Tres

[diizy]

On 08/25/2014 05:51 PM, Tres Finocchiaro wrote:

@diizy https://github.com/diizy, I don't think he's getting ahead of
himself because he's just asking where to put the pull request. Isn't
the pull request the place for the granular "why is this changed?"
discussion?

Well, wouldn't it be better to figure that out now so as to reduce
redundant work?

[StakeoutPunch]

While you have valid point about people wanting certain sounds, there is also the idea that users could create their own. Because of that I think the presets should be more balanced in the sounds they offer. When I say remove I am explicitly talking about presets that are extremely similar to other existing presets. A lot of the presets included are also very simple. While we do need some simple presets, I don't think that the library should be full of them because the average user would more than likely be on that level of synthesis anyways.

As for my presets, I have a lot that are based off pulse width and frequency modulation. There are next to zero presets utilizing those modulations.

[StakeoutPunch]

why not concentrate on creating new presets for synths that have very few

I was planning on that after I dealt with the synth I'm most familiar with! Next on the list are LB302 and SID because they are the next synths I am familiar with, but I'm not opposed to working on others as well. I just want to deal with 3OSC first.

[tresf]

Well, wouldn't it be better to figure that out now so as to reduce redundant work?

In this case, I feel being able to see which ones removed and why would take out any guesswork or speculative questions. If I read his posts correctly, the work has already been done so we just have to determine if it's worth merging, which is hard to say until we can touch it.

[tresf]

Furthermore, we've been talking about cleaning up the presets for a while and even if this merge is rejected, I think it will be a good catalyst for conversation. 🍎

[StakeoutPunch]

If I read his posts correctly, the work has already been done

Nope! I didn't want to start without knowing I wouldn't get sandblasted for changing presets, of all things.

[tresf]

Nope! I didn't want to start without knowing I wouldn't get sandblasted for changing presets, of all things.

Ah... Then this certainly is the right place for it sorry for any confusion.

Perhaps then to ease into this you could throw a few specific examples of improvements at the wall and see what sticks?

[StakeoutPunch]

Goals:

Reduce the number of really simple presets.
Remove very similar/duplicate presets.
Tweak presets with various issues (like envelope problems, or fixing FX glitches)
Add unique presets featuring PM or FM modulation
Add unique presets that are not already represented (for example I have this one patch that sounds like an electric oboe)

[Sti2nd]

Sounds good! Less similar and simple presets, more different and advanced presets. I also believe StakeoutPunch has the skills and experience to add some decent presets. If we want some presets to stay, we'll just comment on the pull request.

[StakeoutPunch]

Sounds good. I'm going to go ahead and close this ticket.

When I finish I'll submit a pull request to stable-1.1 as told, and we can discuss from there.