Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 3.1.5 #357

Closed
wants to merge 8 commits into from
Closed

[Release] 3.1.5 #357

wants to merge 8 commits into from

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Feb 14, 2024

Version: 3.1.5

Pull Requests

Fixes for this PR

Checklist:

  • Testing: All new features and bug fixes must have passed unit and e2e tests. Automated test results must be reviewed and approved by at least one member of the JS-SDK team.
  • Documentation: Any changes to the JS-SDK, including new features, modifications, or bug fixes, must be accompanied by updated documentation. This includes API docs, changelogs, and migration guides for breaking changes
  • Deprecation Notices: If the release includes deprecating existing features, a clear deprecation notice (adding deprecated tag to related function) must be provided, including the timeline for when the feature will be removed and guidance for alternative solutions.
  • No tsc warnings: If your branch much follow the configured tsc rules meaning no new warnings or errors should introduced in your branch.
  • Release notes: Contact the docs team to prepare the release note, highlighting new features, improvements, bug fixes, and known issues.

@Ansonhkg Ansonhkg marked this pull request as draft February 14, 2024 14:48
Ansonhkg and others added 3 commits February 15, 2024 16:24
#360)

* use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0

* fmt

* remove problematic process.exit
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ FedericoAmura
✅ Ansonhkg
✅ glitch003
❌ cairomassimo
You have signed the CLA already but the status is still pending? Let us recheck it.

FedericoAmura and others added 3 commits February 15, 2024 18:45
* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* add comment pointing to repo

---------

Co-authored-by: Massimo Cairo <[email protected]>
@Ansonhkg Ansonhkg added the Patch label Feb 16, 2024
* remove ethers from logger

* fmt
@Ansonhkg Ansonhkg closed this Feb 19, 2024
@Ansonhkg Ansonhkg deleted the staging/3.1.5 branch February 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants