Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment pointing to repo #362

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

glitch003
Copy link
Collaborator

Just adds a comment for clarity

@Ansonhkg Ansonhkg changed the base branch from master to staging/3.1.5 February 15, 2024 22:46
@Ansonhkg Ansonhkg merged commit 9031a12 into staging/3.1.5 Feb 15, 2024
3 of 4 checks passed
@Ansonhkg Ansonhkg deleted the fix/add-comment-for-clarity branch February 15, 2024 22:47
@Ansonhkg Ansonhkg mentioned this pull request Feb 15, 2024
5 tasks
@glitch003
Copy link
Collaborator Author

thanks @Ansonhkg !

@Ansonhkg Ansonhkg mentioned this pull request Feb 19, 2024
5 tasks
Ansonhkg added a commit that referenced this pull request Feb 21, 2024
* init release

* feat: fix contracts-sdk (#359)

* use testThis in testThese to unify criteria and fix the pipeline that… (#360)

* use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0

* fmt

* remove problematic process.exit

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type

* add CI run on PRs targeting staging branches (#361)

* add comment pointing to repo (#362)

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* add comment pointing to repo

---------

Co-authored-by: Massimo Cairo <[email protected]>

* prettied

* feature/lit-2511-js-sdk-review-remove-lit-siwe (#373)

* implement new interface to unify session authentication in client (#358)

* implement new interface to unify session authentication in client

* fix eth pkp wallet creation unit test

* update test to use global config

* add test group to CI

* change encryption test to also validate getting session sigs from cache

* remove process termination order included on testThese that was avoiding other tests to run

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* fix rpc constant used in testing

* add empty resourceAbilityRequests to test

* fix and clean test using new session cache interface to sign using PKPEthersWallet

* fix encryption test

* remove old test

* staging

* chore: update readme

* v?

* use throwError function

* remove unnnecessary sessionKeys as they are obtained from cache afterwards

* move authContext validation to function that validates the PKP auth context

* backwards compatibility to avoid a breaking change

* fmt

* fmt

* fix siwe import

---------

Co-authored-by: Massimo Cairo <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>

* remove vanilla js builds (#372)

* Feature/lit 2494 js sdk get rid of lit third party libs (#371)

* remove 3rd party libs

* fix: revert back to fix react

* it works

* cherry picks 735438f 3b0422f

* readme

* resolve conflicts

---------

Signed-off-by: Anson <[email protected]>

* fix: build issues

* chore: bump accs-schema version to 0.0.6

* update accs schemas version (#375)

* update accs schemas version

* 0.0.6 instead cus we pub the dist folder

---------

Co-authored-by: Ansonhkg <[email protected]>

* fix: wrong error message

* Feature/lit 2491 js sdk make delegateeAddresses field optional (#376)

* chore: bump accs-schema version to 0.0.6

* fix: wrong error message

* feat: make delegatee Optional

* feat: add test

* fix: test case & add extra info on logs

* update: test case comment

* feature/lit-2544-js-sdk-remove-vanilla-js-from-readme

* Published version 3.2.0

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Federico Amura <[email protected]>
Co-authored-by: Massimo Cairo <[email protected]>
Co-authored-by: Chris Cassano <[email protected]>
Ansonhkg added a commit that referenced this pull request Feb 22, 2024
* init release

* feat: fix contracts-sdk (#359)

* use testThis in testThese to unify criteria and fix the pipeline that… (#360)

* use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0

* fmt

* remove problematic process.exit

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type

* add CI run on PRs targeting staging branches (#361)

* add comment pointing to repo (#362)

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* add comment pointing to repo

---------

Co-authored-by: Massimo Cairo <[email protected]>

* prettied

* feature/lit-2511-js-sdk-review-remove-lit-siwe (#373)

* implement new interface to unify session authentication in client (#358)

* implement new interface to unify session authentication in client

* fix eth pkp wallet creation unit test

* update test to use global config

* add test group to CI

* change encryption test to also validate getting session sigs from cache

* remove process termination order included on testThese that was avoiding other tests to run

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* fix rpc constant used in testing

* add empty resourceAbilityRequests to test

* fix and clean test using new session cache interface to sign using PKPEthersWallet

* fix encryption test

* remove old test

* staging

* chore: update readme

* v?

* use throwError function

* remove unnnecessary sessionKeys as they are obtained from cache afterwards

* move authContext validation to function that validates the PKP auth context

* backwards compatibility to avoid a breaking change

* fmt

* fmt

* fix siwe import

---------

Co-authored-by: Massimo Cairo <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>

* remove vanilla js builds (#372)

* Feature/lit 2494 js sdk get rid of lit third party libs (#371)

* remove 3rd party libs

* fix: revert back to fix react

* it works

* cherry picks 735438f 3b0422f

* readme

* resolve conflicts

---------

Signed-off-by: Anson <[email protected]>

* fix: build issues

* Check certificate before passing to wasm

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>
Co-authored-by: Federico Amura <[email protected]>
Co-authored-by: Massimo Cairo <[email protected]>
Ansonhkg added a commit that referenced this pull request Feb 22, 2024
* init patch

* Feature/lit 2545 js sdk fix cosmjscrypto (#381)

* fix: should add dependencies to related packages

* fix: include cosmos dependencies

* fix: correct version

* fix: correct version

* Check certificate before passing to wasm (#374)

* init release

* feat: fix contracts-sdk (#359)

* use testThis in testThese to unify criteria and fix the pipeline that… (#360)

* use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0

* fmt

* remove problematic process.exit

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type

* add CI run on PRs targeting staging branches (#361)

* add comment pointing to repo (#362)

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* add comment pointing to repo

---------

Co-authored-by: Massimo Cairo <[email protected]>

* prettied

* feature/lit-2511-js-sdk-review-remove-lit-siwe (#373)

* implement new interface to unify session authentication in client (#358)

* implement new interface to unify session authentication in client

* fix eth pkp wallet creation unit test

* update test to use global config

* add test group to CI

* change encryption test to also validate getting session sigs from cache

* remove process termination order included on testThese that was avoiding other tests to run

* Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356)

* fix rpc constant used in testing

* add empty resourceAbilityRequests to test

* fix and clean test using new session cache interface to sign using PKPEthersWallet

* fix encryption test

* remove old test

* staging

* chore: update readme

* v?

* use throwError function

* remove unnnecessary sessionKeys as they are obtained from cache afterwards

* move authContext validation to function that validates the PKP auth context

* backwards compatibility to avoid a breaking change

* fmt

* fmt

* fix siwe import

---------

Co-authored-by: Massimo Cairo <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>

* remove vanilla js builds (#372)

* Feature/lit 2494 js sdk get rid of lit third party libs (#371)

* remove 3rd party libs

* fix: revert back to fix react

* it works

* cherry picks 735438f 3b0422f

* readme

* resolve conflicts

---------

Signed-off-by: Anson <[email protected]>

* fix: build issues

* Check certificate before passing to wasm

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Ansonhkg <[email protected]>
Co-authored-by: Federico Amura <[email protected]>
Co-authored-by: Massimo Cairo <[email protected]>

* fix: add blockhash to react demo app (#379)

---------

Signed-off-by: Anson <[email protected]>
Co-authored-by: Chris Cassano <[email protected]>
Co-authored-by: Federico Amura <[email protected]>
Co-authored-by: Massimo Cairo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants