Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples and run during e2e build #479

Merged
7 commits merged into from
Dec 16, 2024
Merged

Update examples and run during e2e build #479

7 commits merged into from
Dec 16, 2024

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Dec 13, 2024

Add a PaladinVerifier type to the SDK for storing and resolving Paladin identities.

Update the examples to use this new type, and run all of the examples as part of gradle e2e (to help ensure the examples stay functional).

Signed-off-by: Andrew Richardson <[email protected]>
@awrichar awrichar changed the title Update examples and run during build Update examples and run during e2e build Dec 13, 2024
Signed-off-by: Andrew Richardson <[email protected]>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As I've noticed we have an issue with the existing E2E for Bonds failing in main - I'm going to pull this into my branch for #472 to get better validation there too.

I'll work to get the build there green, and this can merge through that.

Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - updates look good, and I've pulled them into #472

@peterbroadhurst peterbroadhurst closed this pull request by merging all changes into main in b812a05 Dec 16, 2024
@peterbroadhurst peterbroadhurst deleted the paladin-sdk branch December 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants