Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure assemble always loads TX data locally, and on-chain enforcement of TXID uniqueness #472

Merged
merged 24 commits into from
Dec 16, 2024
Merged

Ensure assemble always loads TX data locally, and on-chain enforcement of TXID uniqueness #472

merged 24 commits into from
Dec 16, 2024

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Dec 10, 2024 •
edited
Loading

  • Add interface to TXManager to query transactions from local sender DB
    • With caching for performance as we query very quickly after insert
    • With query interface for paging TXs in for private tx mgr after restart
    • With by-ID semantics for private TX mgr before servicing an assemble
    • With cache-backed resolution of function to ABI
  • Wire up new interface to private TX mgr
    • Removed duplicative struct type definitions, and reconciled the code quite a bit as a result.
    • Updated the testbed to work with the new code interfaces (still has its own implementation of all the structures)
    • Ensure we validate the domain on private transactions before storing
    • Ensure the E2E passes - pulling in Update examples and run during e2e build #479 as part of this as main has an issue with E2E
  • Update Pente to ensure at-most-once use of TXIDs on-chain
    • I'm deferring noto and zeto as the replay attack considerations there are slightly different, so @jimthematrix and @awrichar can consider those individually.

@peterbroadhurst peterbroadhurst changed the title Provide interface with caching on TXMgr to query txns with resolved fns Ensure assemble always loads TX data locally, and on-chain enforcement of TXID uniqueness Dec 10, 2024
peterbroadhurst and others added 15 commits December 10, 2024 13:37
@peterbroadhurst
Work through changes to include post-commit cache update to other com…
301219b 
…ponents

Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Remove duplicative data structures and update domainmgr interface to …
05dd571 
…separate out TX input data

Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Work through removal of duplicate structures and not sending TX input…
12c4ea4 
… data cross-node

Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Work through private TX mgr test changes for updated assemble interac…
922c4dd 
…tions

Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Work through testbed transaction updates
af0284f 
Signed-off-by: Peter Broadhurst <[email protected]>
@awrichar
sdk: add PaladinVerifier type
6c9f5c7 
Signed-off-by: Andrew Richardson <[email protected]>
@awrichar
example: update examples and run them during "e2e" task
cc6d99f 
Signed-off-by: Andrew Richardson <[email protected]>
@peterbroadhurst
Propagate function ABI in testbed when auto-chaining
ddd54d0 
Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Merge branch 'main' into one-time-intents
90ffae8
@awrichar
sdk: update version
a0e5168 
Signed-off-by: Andrew Richardson <[email protected]>
@peterbroadhurst
Merge branch 'main' of https://github.com/kaleido-io/paladin into one…
7b63897 
…-time-intents
@peterbroadhurst
Merge branch 'one-time-intents' of https://github.com/kaleido-io/paladin
9dfdb6a 
 into one-time-intents
@peterbroadhurst
Merge conflict in testbed
83b85a6 
Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Add duplicate TX rejection on-chain in Pente
f55a688 
Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst
Merge branch 'paladin-sdk' of https://github.com/kaleido-io/paladin i…
34632f0 
…nto one-time-intents
@peterbroadhurst peterbroadhurst mentioned this pull request Dec 13, 2024
Merged
@peterbroadhurst peterbroadhurst marked this pull request as ready for review December 14, 2024 00:39
@awrichar
sdk: add decodeTransactionEvents
26d5e30 
Signed-off-by: Andrew Richardson <[email protected]>
@peterbroadhurst peterbroadhurst mentioned this pull request Dec 16, 2024
Merged
hosie
hosie approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@hosie hosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbroadhurst peterbroadhurst merged commit b812a05 into main Dec 16, 2024
7 checks passed
@peterbroadhurst peterbroadhurst deleted the one-time-intents branch December 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosie hosie hosie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbroadhurst @hosie @awrichar