Fix missing dependencies and minor package.xml fixes for simulation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cense; add new dependencies that were missing
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package.xml with detailed description, maintainer info, and license; add new dependencies that were missing
What type of PR is this? (check all applicable)
Description
We must get better at declaring dependencies and more generally providing correct
package.xmlfiles. This particular fix was needed as @gcielniak reported the simulation in the devcontainer of https://github.com/LCAS/ROB2002/ not having the sensor topics as thegazebo_pluginswere not declared.QA Instructions, Screenshots, Recordings
@gcielniak to try if his simulation now works