Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation Setup improvements #524

Closed
bsteubing opened this issue Feb 11, 2021 · 2 comments
Closed

Calculation Setup improvements #524

bsteubing opened this issue Feb 11, 2021 · 2 comments
Assignees
@dgdekoning
Labels
feature Issues/PRs related to a new feature

Comments

@bsteubing
Copy link
Member

It would be great to have these two features:

  1. Ability to reorder items in the lists in calculation setups (reference flows, impact categories)
  2. Ability to do LCA calculations for selected items in those lists (checkboxes that are by default selected)

For 2. an alternative could be to have a repeated version of the "calculation setup" under "LCA results" with checkboxes so that one can unselect reference flows or activities or scenarios and thereby "filter" the analysis a bit.
@marc-vdm
Copy link
Member

marc-vdm commented Feb 11, 2021 •
edited
Loading

For 2. I think your added suggestion on filtering results would have more added value than selecting/filtering them beforehand

edit:
This would also have added value with different sets of scenario files and looking at only specific combinations.

Additional thought:
What about having both options for 2? Allowing selection beforehand and afterwards. This would still calculate all items but already sets a 'preset' for what results are shown.

@dgdekoning dgdekoning added the feature Issues/PRs related to a new feature label Feb 12, 2021
@marc-vdm marc-vdm mentioned this issue Feb 9, 2022
Closed
marc-vdm added a commit to marc-vdm/activity-browser that referenced this issue Feb 17, 2022
@marc-vdm
Enable re-ordering of reference flows/impact categories in calculatio…
00b2a66 
…n setup. (fixes LCA-ActivityBrowser#571 and partially LCA-ActivityBrowser#524)

+ Added tooltip on tables
+ Users can also hold CTRL to select multiple items at once
@marc-vdm marc-vdm mentioned this issue Feb 17, 2022
Merged
bsteubing pushed a commit that referenced this issue Feb 17, 2022
@marc-vdm
Minor calculation setup updates (#719)
89f66ac 
* New screen when no calculation setups exist (fix for #620)
+ Hiding of 'Copy' button when no calculation setups exist

* Insert splitter between reference flows and impact categories tables to allow user-resizing (fix for #532)

* Enable re-ordering of reference flows/impact categories in calculation setup. (fixes #571 and partially #524)
+ Added tooltip on tables
+ Users can also hold CTRL to select multiple items at once

* Changing activity product is now reflected in reference flows table in calculation setup (fix #533)

* Fix edgecase bug (#699)
This was referenced Feb 18, 2022
Closed
Open
@bsteubing
Copy link
Member Author

I close this issue as I think the discussion should move to #728

haasad pushed a commit to haasad/activity-browser that referenced this issue Feb 19, 2022
@marc-vdm @haasad
Minor calculation setup updates (LCA-ActivityBrowser#719)
2afb40c 
* New screen when no calculation setups exist (fix for LCA-ActivityBrowser#620)
+ Hiding of 'Copy' button when no calculation setups exist

* Insert splitter between reference flows and impact categories tables to allow user-resizing (fix for LCA-ActivityBrowser#532)

* Enable re-ordering of reference flows/impact categories in calculation setup. (fixes LCA-ActivityBrowser#571 and partially LCA-ActivityBrowser#524)
+ Added tooltip on tables
+ Users can also hold CTRL to select multiple items at once

* Changing activity product is now reflected in reference flows table in calculation setup (fix LCA-ActivityBrowser#533)

* Fix edgecase bug (LCA-ActivityBrowser#699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgdekoning dgdekoning

Labels
feature Issues/PRs related to a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StpdFox @dgdekoning @bsteubing @marc-vdm