Added tests for LongitudinalProfileFromData and fix for issue #185 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests to allow for longitudinal profile from spectral data, whether monotonically increasing or decreasing
Editing LongitudinalProfileFromData to allow for monotonically decreasing spectral data
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Updated tests for monotonically increasing or decreasing specta
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Wavelength and wavelength axis given different names
for more information, see https://pre-commit.ci
Analytic ft of GaussianLongitudinalProfile needs checking
Analytic spectrum checked in separate script
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
em-archer
changed the title
em-archer
changed the title
…omega When data["datatype"] = "spectral", data["axis"] can either be wavelength lambda in m or angular frequency omega in s^-1. The user doesn't need to specify, it will automatically detect and convert to wavelength if the latter is passed.
for more information, see https://pre-commit.ci
|
Also added small update to also accept angular spectrum data (units of s^-1) instead of wavelength data |
MaxThevenet
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thanks for this PR! Really great to have more tests, and the option to initialise from file while passing the angular frequency instead of wavelength will be useful, in particular for @Paaaaarth in PR #296. Besides a minor suggestion in the text, I have two comments:
- Determining whether it is wavelength or frequency depending on the value is IMO not very straightforward. Would it be possible to make the user provide specific arguments? The user could provide
datatype = spectralas before, but there could be one additional argumentaxis_is_wavelengthwith defaultTrue, and if set toFalsethe axis is supposed to be frequency. I think this parameter would appear clearly in the doc and should make it clear to the users. - When converting from axis = frequency to wavelength, shouldn't we also modify the spectrum by multiplying with
$2\pi c / \lambda^2$ or so? Not sure this is done in the current reader, could you check this?
tests/test_laser_profiles.py
Outdated
| @@ -234,6 +238,89 @@ def test_longitudinal_profiles(): | |||
| print("cep_phase = ", cep_phase_cos) | |||
| assert np.abs(cep_phase_cos - cep_phase) / cep_phase < 0.02 | |||
|
|
|||
| # LongitudinalProfileFromData | |||
| print("LongitudinalProfileFromData") | |||
| data = {} # Generate spectral data assuming analytic ft of GaussianLongitudinalProfile | |||
There was a problem hiding this comment.
Is this correct? Just to make it more explicit.
Suggested change
| data = {} # Generate spectral data assuming analytic ft of GaussianLongitudinalProfile | |
| data = {} # Generate spectral data assuming analytic Fourier transform of GaussianLongitudinalProfile |
User must now specify axis type (wavelength by default). Also added proper conversion for spectral intensity if axis is omega.
for more information, see https://pre-commit.ci
MaxThevenet
reviewed
Oct 16, 2024
Co-authored-by: Maxence Thévenet <[email protected]>
Co-authored-by: Maxence Thévenet <[email protected]>
|
Superseded by #309. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing LongitudinalProfileFromData to allow for monotonically decreasing spectral data (fix for #185) and adding relevant tests to test_laser_profiles. Currently no tests exist for LongitudinalProfileFromData, so adding tests for monotonically increasing/decreasing spectral data. Test for temporal data could be added in future.