Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laser wavelength must be monotonically increasing in LongitudinalProfileFromData #185

Open
rob-shalloo opened this issue Oct 9, 2023 · 0 comments
Labels
bug Something isn't working good first issue

Comments

@rob-shalloo
Copy link
Member

Have just come across a bug when using the LongitudinalProfileFromData profile in the spectral domain that the wavelength must be monotonically increasing. If the spectrum extends for example from 1000 nm to 500 nm rather than 500 nm to 1000 nm, then the function fails to produce something sensible.

The fix should be relatively straightforward by checking this condition and either adding an assert or flipping the array

@rob-shalloo rob-shalloo added bug Something isn't working good first issue labels Oct 9, 2023
MaxThevenet added a commit that referenced this issue Oct 17, 2024
)

Co-authored-by: “Emily <“[email protected]”>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maxence Thévenet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue
Projects
None yet
Development

No branches or pull requests

1 participant