api: Add methods to join components using a collector #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
reviewed
Feb 28, 2021
| * @return the list of children | ||
| * @since 4.6.0 | ||
| */ | ||
| @NonNull List<Component> children(); |
There was a problem hiding this comment.
it's not strictly required -- the collector could just work with the builder implementation -- but it feels weird to not expose functionality the collector needs to the api.
There was a problem hiding this comment.
I'm not really a fan of exposing getters on builders... but it looks like we do for content() as well, so I guess this is okay.
kashike
requested changes
Mar 1, 2021
api/src/test/java/net/kyori/adventure/text/AbstractComponentTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/net/kyori/adventure/text/AbstractComponentTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Riley Park <[email protected]>
kashike
approved these changes
Mar 1, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-286