Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TextComponent.ofChildren(ComponentLike...) into Component #418

Closed
kezz opened this issue Jul 26, 2021 · 3 comments · Fixed by #344
Closed

Move TextComponent.ofChildren(ComponentLike...) into Component #418

kezz opened this issue Jul 26, 2021 · 3 comments · Fixed by #344
Milestone

Comments

@kezz
Copy link
Member

kezz commented Jul 26, 2021

In line with the rest of the API having static methods on Component, this one should also live in Component and just return a Component instead of a TextComponent.

@kezz kezz added the area: api label Jul 26, 2021
@zml2008
Copy link
Member

zml2008 commented Jul 26, 2021

hmm, i'd thought about this but got stuck on what to call the method in Component -- wrap? of, text(List<? extends ComponentLike>)?

@zml2008 zml2008 added this to the 4.9.0 milestone Jul 26, 2021
@kezz
Copy link
Member Author

kezz commented Jul 26, 2021

could be part of #344 or maybe another collector method? otherwise, maybe joinAsSiblings or something?

@kezz
Copy link
Member Author

kezz commented Jul 27, 2021

Actually, it's worth noting that Component.join(JoinConfig.noSeparators(), components) would be functionally identical to the ofChildren method. My vote would be to just deprecate this method alongside #344 and mark the new JoinConfig system as the replacement.

@kezz kezz linked a pull request Aug 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants