Show correct wallet to add token to, in Transaction modal #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hungdoansy
force-pushed
the
refactor/update-add-token-to-wallet-modal
branch
from
dd683ce
to
8f665d7
Compare
Auto Deploy Pull RequestYour domain kyberswap-interface-1260.pr.kyberengineering.io has been created. Notes
|
hungdoansy
force-pushed
the
refactor/update-add-token-to-wallet-modal
branch
from
8f665d7
to
87f845c
Compare
viet-nv
reviewed
Aug 18, 2022
hungdoansy
force-pushed
the
refactor/update-add-token-to-wallet-modal
branch
from
87f845c
to
c7d633e
Compare
viet-nv
approved these changes
Aug 18, 2022
Auto Deploy Pull RequestYour domain kyberswap-interface-1260.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
viet-nv
added a commit
that referenced
this pull request
Aug 21, 2022
* fix bug params currency (#1244) * feat(campaign): enter now go to swap with first eligible token (#1240) * Change Banner to Polygon Campaign (#1245) * feat(farm): elastic (#1247) * fix: staked amount (#1248) * fix: farm apr (#1249) * improve: farm ux (#1250) * Do minor UI improvement (#1246) * chore: increase gap in TransactionConfirmationModal * chore: gap in TransactionPopup * chore: adjust spacing in EnterNow in Campaign page * chore: add a hyper link to Elastic pools from Farm * feat(pools): add button to hide pools with low TVL * refactor(about): update to new style/texts * fix: apr farm (#1252) * fix(trending-token-banner): avoid words from breaking at white spaces (#1251) * Support Brave wallet (#1221) * feat: support Brave wallet * refactor(PendingView): simplify props * simplify checkForBraveBrowser * chore: update return type of onClickTryAgain * fix: display Brave wallet identicon * fix: display wallet options on Brave In Brave, window.ethereum is not undefined, so a condition fails and there are no wallet options to choose. * chore(wallet-modal): show hover effect on supported devices only * fix: display correct wallet name by detecting connector * fix bug popup noti overlap + import token(#1255) * fix bug popup noti overlap * fix bug import token * feat: add banner for polygon lido farming (#1256) * fix: hide ATH pro live chart * redact wallet address and tx_hash * switch basic chart to priorities coingecko api * revert debug * hide ATH pro live chart Co-authored-by: nguyenhuudungz <[email protected]> * fix: ath price chart and reward price (#1258) * fix(farm): get reward token price from market (#1259) * feat: tutorial swap page (#1192) * refactor(tx-modal): show correct wallet to add token to (#1260) * chore: update .env.dev (#1262) * feat: support emergency withdraw (#1263) * add top banner (#1264) * update blog link * fix(farm): mistake in withdraw condition * fix: update text (#1265) * fix: can not withdraw on ended tab (#1266) * feat: switch banner position (#1267) * fix: can not withdraw on ended tab (#1268) * Update nginx.conf * refactor: remove unused constant (#1269) * fix: revert to public rpc for bsc Co-authored-by: Nguyễn Hoài Danh <[email protected]> Co-authored-by: nguyenhuudungz <[email protected]> Co-authored-by: Kami Ho <[email protected]> Co-authored-by: Hung Doan <[email protected]> Co-authored-by: XiaoYhun <[email protected]> Co-authored-by: Viet-Anh Duong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After submitting a tx, there's a tx modal poping up and there's a button to add the token to the wallet.
Before, it was fixed to Metamask, even if Coin98 or Brave is being used
After, wallet detection is added. Only injected wallets will have that button. If it's the injected wallet used by TrustWallet in-app browser, the button will be 'Add token to your wallet'
Before:
