Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug params currency #1244

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix bug params currency #1244

merged 1 commit into from
Aug 15, 2022

Conversation

nguyenhoaidanh
Copy link
Contributor

@nguyenhoaidanh nguyenhoaidanh commented Aug 12, 2022

  • move some modules from dependency to devdependency
  • fix bug: When wallet is not connected, visit link at swap?networkId=56&outputCurrency=0x261C94f2d3CcCAE76f86F6C8F2C93785DD6cE022 it can not select ATH for us

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1244.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

},
[Field.OUTPUT]: {
currencyId: '',
currencyId: outputCurrency?.toString() || '',
Copy link
Contributor Author

@nguyenhoaidanh nguyenhoaidanh Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we visit web the first time, if inputCurrency/outputCurrency exist in url. set it to default value of initialState .
This will reduce the number of times re-render.
Because

  • if url is. /swap?inputCurrency=xxx ==> state change from '' => xxx. it cause my app rerender.

@nguyenhoaidanh nguyenhoaidanh marked this pull request as ready for review August 15, 2022 02:47
@viet-nv
Copy link
Member

viet-nv commented Aug 15, 2022

move some modules from dependency to devdependency
actually, this doesnt affect anything to bundle size

@viet-nv viet-nv closed this Aug 15, 2022
@viet-nv viet-nv reopened this Aug 15, 2022
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1244.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

1 similar comment
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1244.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nguyenhoaidanh
Copy link
Contributor Author

nguyenhoaidanh commented Aug 15, 2022

move some modules from dependency to devdependency
actually, this doesnt affect anything to bundle size

@viet-nv
I put it into the right place that they should be. ex: eslint-... , @type/.... it is for development purpose, should be devdependency.

@viet-nv
Copy link
Member

viet-nv commented Aug 15, 2022

move some modules from dependency to devdependency
actually, this doesnt affect anything to bundle size

@viet-nv I put it into the right place that they should be. ex: eslint-... , @type/.... it is for development purpose, should be devdependency.

ah yeah, I know. just for visualize

Copy link
Member

@viet-nv viet-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyenhoaidanh nguyenhoaidanh merged commit 7ab9429 into main Aug 15, 2022
@nguyenhoaidanh nguyenhoaidanh deleted the danh/fix-bug-params-currency branch August 15, 2022 06:25
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1244.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

viet-nv added a commit that referenced this pull request Aug 21, 2022
* fix bug params currency (#1244)

* feat(campaign): enter now go to swap with first eligible token (#1240)

* Change Banner to Polygon Campaign (#1245)

* feat(farm): elastic (#1247)

* fix: staked amount (#1248)

* fix: farm apr (#1249)

* improve: farm ux (#1250)

* Do minor UI improvement (#1246)

* chore: increase gap in TransactionConfirmationModal

* chore: gap in TransactionPopup

* chore: adjust spacing in EnterNow in Campaign page

* chore: add a hyper link to Elastic pools from Farm

* feat(pools): add button to hide pools with low TVL

* refactor(about): update to new style/texts

* fix: apr farm (#1252)

* fix(trending-token-banner): avoid words from breaking at white spaces (#1251)

* Support Brave wallet (#1221)

* feat: support Brave wallet

* refactor(PendingView): simplify props

* simplify checkForBraveBrowser

* chore: update return type of onClickTryAgain

* fix: display Brave wallet identicon

* fix: display wallet options on Brave

In Brave, window.ethereum is not undefined, so a condition fails and there are no wallet options to choose.

* chore(wallet-modal): show hover effect on supported devices only

* fix: display correct wallet name by detecting connector

* fix bug popup noti overlap + import token(#1255)

* fix bug popup noti overlap 

* fix bug import token

* feat: add banner for polygon lido farming (#1256)

* fix: hide ATH pro live chart

* redact wallet address and tx_hash

* switch basic chart to priorities coingecko api

* revert debug

* hide ATH pro live chart

Co-authored-by: nguyenhuudungz <[email protected]>

* fix: ath price chart and reward price (#1258)

* fix(farm): get reward token price from market (#1259)

* feat: tutorial swap page  (#1192)

* refactor(tx-modal): show correct wallet to add token to (#1260)

* chore: update .env.dev (#1262)

* feat: support emergency withdraw (#1263)

* add top banner (#1264)

* update blog link

* fix(farm): mistake in withdraw condition

* fix: update text (#1265)

* fix: can not withdraw on ended tab (#1266)

* feat: switch banner position (#1267)

* fix: can not withdraw on ended tab (#1268)

* Update nginx.conf

* refactor: remove unused constant (#1269)

* fix: revert to public rpc for bsc

Co-authored-by: Nguyễn Hoài Danh <[email protected]>
Co-authored-by: nguyenhuudungz <[email protected]>
Co-authored-by: Kami Ho <[email protected]>
Co-authored-by: Hung Doan <[email protected]>
Co-authored-by: XiaoYhun <[email protected]>
Co-authored-by: Viet-Anh Duong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants