-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug params currency #1244
fix bug params currency #1244
Conversation
Auto Deploy Pull RequestYour domain kyberswap-interface-1244.pr.kyberengineering.io has been created. Notes
|
}, | ||
[Field.OUTPUT]: { | ||
currencyId: '', | ||
currencyId: outputCurrency?.toString() || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we visit web the first time, if inputCurrency/outputCurrency exist in url. set it to default value of initialState .
This will reduce the number of times re-render.
Because
- if url is.
/swap?inputCurrency=xxx
==> state change from''
=>xxx
. it cause my app rerender.
|
Auto Deploy Pull RequestYour domain kyberswap-interface-1244.pr.kyberengineering.io has been created. Notes
|
1 similar comment
Auto Deploy Pull RequestYour domain kyberswap-interface-1244.pr.kyberengineering.io has been created. Notes
|
@viet-nv |
ah yeah, I know. just for visualize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Auto Deploy Pull RequestYour domain kyberswap-interface-1244.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
* fix bug params currency (#1244) * feat(campaign): enter now go to swap with first eligible token (#1240) * Change Banner to Polygon Campaign (#1245) * feat(farm): elastic (#1247) * fix: staked amount (#1248) * fix: farm apr (#1249) * improve: farm ux (#1250) * Do minor UI improvement (#1246) * chore: increase gap in TransactionConfirmationModal * chore: gap in TransactionPopup * chore: adjust spacing in EnterNow in Campaign page * chore: add a hyper link to Elastic pools from Farm * feat(pools): add button to hide pools with low TVL * refactor(about): update to new style/texts * fix: apr farm (#1252) * fix(trending-token-banner): avoid words from breaking at white spaces (#1251) * Support Brave wallet (#1221) * feat: support Brave wallet * refactor(PendingView): simplify props * simplify checkForBraveBrowser * chore: update return type of onClickTryAgain * fix: display Brave wallet identicon * fix: display wallet options on Brave In Brave, window.ethereum is not undefined, so a condition fails and there are no wallet options to choose. * chore(wallet-modal): show hover effect on supported devices only * fix: display correct wallet name by detecting connector * fix bug popup noti overlap + import token(#1255) * fix bug popup noti overlap * fix bug import token * feat: add banner for polygon lido farming (#1256) * fix: hide ATH pro live chart * redact wallet address and tx_hash * switch basic chart to priorities coingecko api * revert debug * hide ATH pro live chart Co-authored-by: nguyenhuudungz <[email protected]> * fix: ath price chart and reward price (#1258) * fix(farm): get reward token price from market (#1259) * feat: tutorial swap page (#1192) * refactor(tx-modal): show correct wallet to add token to (#1260) * chore: update .env.dev (#1262) * feat: support emergency withdraw (#1263) * add top banner (#1264) * update blog link * fix(farm): mistake in withdraw condition * fix: update text (#1265) * fix: can not withdraw on ended tab (#1266) * feat: switch banner position (#1267) * fix: can not withdraw on ended tab (#1268) * Update nginx.conf * refactor: remove unused constant (#1269) * fix: revert to public rpc for bsc Co-authored-by: Nguyễn Hoài Danh <[email protected]> Co-authored-by: nguyenhuudungz <[email protected]> Co-authored-by: Kami Ho <[email protected]> Co-authored-by: Hung Doan <[email protected]> Co-authored-by: XiaoYhun <[email protected]> Co-authored-by: Viet-Anh Duong <[email protected]>
dependency
todevdependency
swap?networkId=56&outputCurrency=0x261C94f2d3CcCAE76f86F6C8F2C93785DD6cE022
it can not select ATH for us