Remove deprecated Android package override #226
Conversation
This responds to a [breaking change](facebook/react-native@ce6fb33) in React Native 0.47.0.
|
I think that simply commenting line 23 instead of removing the whole method is a better idea, since it should be backward compatible. |
| public List<Class<? extends JavaScriptModule>> createJSModules() { | ||
| return Collections.emptyList(); | ||
| } | ||
| */ |
There was a problem hiding this comment.
Can we fix indentation before its merged, please?
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| // if react native < 47, open code |
There was a problem hiding this comment.
Can you be so kind to move this comment under multiline comment block? /* ... */?
|
Removing the whole method will brake on RN <0.47. |
|
3.1.3 has been released with the similar patch (just removing |
Fixed crashed when compile with RN > 0.47+ Related discussion Kureev/react-native-blur#226
| } | ||
|
|
||
| // if react native < 47, open code | ||
| /* @Override |
There was a problem hiding this comment.
all one needs to do is comment out just @Override statement instead of the entire method. Reason being purely backward compatibility
|
npm uninstall react-native-code-push --save then npm i react-native-code-push --save |
This responds to a breaking change in React Native 0.47+