Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: method does not override or implement a method from a supertype @Override #219

Closed
Amurmurmur opened this issue Jul 6, 2017 · 3 comments
Closed

error: method does not override or implement a method from a supertype @Override #219

Amurmurmur opened this issue Jul 6, 2017 · 3 comments

Comments

@Amurmurmur
Copy link

Starts to happen when upgraded to RN 0.47.0-rc.0, when comping on android:

:react-native-blur:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/amurmurmur/exampleapp/node_modules/react-native-blur/android/src/main/java/com/cmcewen/blurview/BlurViewPackage.java:23: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /Users/amurmurmur/exampleapp/node_modules/react-native-blur/android/src/main/java/com/cmcewen/blurview/BlurringView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
:react-native-blur:compileReleaseJavaWithJavac FAILED

How can it be fixed?
Thank you in advance
@TrustDec
Copy link

TrustDec commented Aug 3, 2017 •
edited
Loading

Look here

@PeterEmanuel
Copy link

Does this mean that the packages/projects that I link in my app have to be fixed for this?
Not funny, if this is true...

@Kureev
Copy link
Owner

Kureev commented Aug 8, 2017

Fixed in 3.1.3

@Kureev Kureev closed this as completed Aug 8, 2017
lxp-git pushed a commit to Flickering-AI/react-native-blur that referenced this issue Mar 7, 2022
@jakub-gonet @kmagiera
[v1] Fix flickering on mount (#1027)
a766390 
Fixes Kureev#219
Fixes #762

Previously components were flickering when mounted due to asynchronously updating component styles.

In `createAnimatedComponent()` we filtered out styles with Animated nodes, then component rendered with default values,
then nodes were initialized on the native side and applied their styles.
This issue was mostly observed when layout styles were changed, for example when setting height like in the example below.

This fix relies on updating the value of `Value` when nodes are detached (`__detach()` in `InternalAnimatedValue`) because it updates its value on the JS side. Without that this fix would only work on the first mount (when initial values are used). It also doesn't support any nested properties (like transform).

```js
import * as React from 'react';
import {Button, Text, View} from 'react-native';
import Animated from 'react-native-reanimated';

export default function Flickering() {
  const value = Animated.useValue(80);
  const [i, setI] = React.useState(0);
  const triggerRemount = () => {
    setI(i => i + 1);
  };
  return (
    <View
      key={i}
      style={{
        height: '100%',
        backgroundColor: 'white',
        position: 'relative',
        paddingTop: 100,
      }}>
      <Animated.View
        style={{
          height: value,
          position: 'absolute',
          width: '100%',
          backgroundColor: 'green',
        }}>
        <Text style={{color: 'white', fontSize: 15}}>Some footer</Text>
      </Animated.View>
      <Button
        onPress={() => {
          triggerRemount();
        }}
        style={{marginTop: 100}}
        title="Trigger remount!"
      />
    </View>
  );
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PeterEmanuel @Kureev @Amurmurmur @TrustDec