Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build windows wheels #1302

Closed
wants to merge 8 commits into from
Closed

feat: build windows wheels #1302

wants to merge 8 commits into from

Conversation

naveen521kk
Copy link
Contributor

@naveen521kk naveen521kk commented Mar 2, 2021

fixes #1241
TODO:

If anyone wants to try I had already built a wheel.
WeasyPrint-53.0-py3-none-win_amd64.zip

@naveen521kk
Copy link
Contributor Author

@liZe is there any smoke tests that can be run to test those wheels?

@naveen521kk naveen521kk marked this pull request as ready for review March 3, 2021 07:41
@naveen521kk naveen521kk changed the title WIP: feat: build windows wheels feat: build windows wheels Mar 3, 2021
@naveen521kk
Copy link
Contributor Author

Any chance for reviewing it?

@liZe
Copy link
Member

liZe commented Mar 14, 2021

Any chance for reviewing it?

Hello @naveen521kk.

Thanks for your hard work on this pull request, we’re sorry we took so much time to answer.

It’s a bit complicated right now for us to review this pull request, because there’s a lot of things going on with version 53: new packaging, new dependencies, etc. Moreover, providing wheels with embedded libraries is a really important decision, because it’s almost mandatory to provide them forever. It adds code that we’ll have to maintain and to test, knowing that we don’t have Windows installed on our computers.

The ideal solution would include:

  • no extra Python code,
  • a whole automation of packaging,
  • packaging tests for all supported platforms.

Of course, this dream is a lot of work (if it’s ever possible 😉, that’s sometimes the problem with dreams). This PR is definitely a huge step in the right direction, and we’re very grateful for that, but both fixing the technical details and accepting the little cute puppy will take some time 🐕.

@naveen521kk
Copy link
Contributor Author

It adds code that we’ll have to maintain and to test, knowing that we don’t have Windows installed on our computers.

You can always ping me, I should be able to help if things don't work :)
I have documented the code I wrote so that it doesn't create problems and is easy for anybody to understand.

no extra Python code,

I thought it should be better to use python rather than batch or PowerShell? Anyway, this shouldn't create problems, I believe.

a whole automation of packaging,

As you can see it is automated. Both the pango-build(which I will any maintain for another project) and Github Actions here automatically builds things. It builds and also runs a simple command as a test see the GitHub workflow I added in this PR.

packaging tests for all supported platforms.

I think it makes sense to pack only for Windows because for Linux it is there, by default, or can easily be installed through the package manager. The same is for macOS, they have Brew.

@naveen521kk
Copy link
Contributor Author

Is it possible to review this at least now?

@naveen521kk naveen521kk closed this Jul 1, 2021
@naveen521kk naveen521kk deleted the feat-wheels branch July 1, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels with compiled libraries
2 participants