feat: implemented new UI for Navbar and Table of Contents #3917
Conversation
berezinant
force-pushed
the
ktl-1607-filters
branch
from
dcf5e64
to
b371df4
Compare
berezinant
force-pushed
the
ktl-1607-filters
branch
2 times, most recently
from
900ee9e
to
7c434b8
Compare
| @@ -32,7 +32,23 @@ | |||
| <@header.display/> | |||
| <div id="container"> | |||
| <div class="sidebar" id="leftColumn"> | |||
| <div class="sidebar--inner" id="sideMenu"></div> | |||
| <div class="dropdown theme-dark_mobile" data-role="dropdown" id="toc-dropdown"> | |||
There was a problem hiding this comment.
just to recheck: if users override template (e.g. for kotlinlang) everything will continue to work fine?
I mean, kotlinx.* libraries will be able to just update to Dokka 2.0.0 and everything will be fine, right?
There was a problem hiding this comment.
Yes, I've just double checked, custom templates will still work.
However it will be needed update custom templates to align them with the changes in our templates, we'll write about it in the release notes and provide links to the templates in this PR as a reference
There was a problem hiding this comment.
Thanks!
And what will be the result if the templates will not be updated?
I mean, for now the only thing worries me here is kotlinx.* libraries because their templates are stored in kotlin-web-site repository and used by all other kotlinx libraries.
Let's imagine a case that kotlinx.coroutines will update to Dokka 2.0.0 but kotlinx.serialization will still use Dokka 1.9.20 - they will both use the same templates - how the final result will look for both libraries?
There was a problem hiding this comment.
We will need to update api references for kotlinx- libraries at kotlinlang simultaneously
berezinant
force-pushed
the
ktl-1607-filters
branch
from
7c434b8
to
37c0921
Compare
* feat: implemented new button states * fix: button stories
* ktl-1608 feat: search adjustments * fix: fixed focus style for search button --------- Co-authored-by: Yuri Teplyakov <[email protected]>
* feat: implemented new button states * ktl-1608 feat: style fixes * ktl-1608 feat: fix clear button * fixes after rebase --------- Co-authored-by: berezinant <[email protected]>
* feat: implemented new button states * feat: reworked ToC appearance * fix: moved images to assets * fix: fix toc interactivity * fix: fixed problem with hover on touch screens * fix: open toc no mobile * fix scripts loading in safari * fix: fixed overlap of dropdown with toc on desktop * fix: fixed closing toc on mobile * fix: versions dropdown position * fix: version selector position
* ktl-1727 fix: fix safari flickering * ktl-1737 fix: fix version capitalization
berezinant
force-pushed
the
ktl-1607-filters
branch
from
9fdc58b
to
a73d458
Compare
berezinant
force-pushed
the
ktl-1607-filters
branch
from
a73d458
to
76a7004
Compare
No description provided.