feat: implemented new button states #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezinant
force-pushed
the
ktl-1564-navbar
branch
from
0522f93
to
3dd2bc9
Compare
berezinant
force-pushed
the
ktl-1620-button
branch
from
fb44e16
to
32f0acf
Compare
berezinant
force-pushed
the
ktl-1564-navbar
branch
from
3dd2bc9
to
1af89c3
Compare
berezinant
force-pushed
the
ktl-1620-button
branch
from
32f0acf
to
e848686
Compare
berezinant
force-pushed
the
ktl-1564-navbar
branch
from
1af89c3
to
29999ba
Compare
berezinant
force-pushed
the
ktl-1620-button
branch
from
e848686
to
e4f3341
Compare
zoobestik
reviewed
Oct 1, 2024
zoobestik
approved these changes
Oct 1, 2024
|
@berezinant is it intended that icon and label item doesn't show label on the screenshots? |
|
@akiya-nagatsuka thanks for noticing, it's an issue with example, I've fixed it. As for the button component itself, it works ok in this case |
berezinant
added a commit
that referenced
this pull request
Oct 1, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Oct 21, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 7, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 21, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 25, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 25, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Nov 28, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Dec 2, 2024
* feat: implemented new button states * fix: button stories
berezinant
added a commit
that referenced
this pull request
Dec 2, 2024
* feat: reworked navbar according to new design (#3668) * feat: implemented new button states (#3737) * feat: implemented new button states * fix: button stories * feat: implement dropdown menu with checkboxes * fix: fixed dropdown on mobile and reorganized assets * fix: fixed dropdown on tablet * feat: sync platform tags with platform tag dropdown * feat: sync platform tags with platform tag dropdown * feat: implemented checkbox * feat: sync platform tags and dropdown options * fix: prevent blinking when loading tags * fix: show filters button instead of dropdown when no tags are displayed * fix: sync localstorage with filters om mobile * feat: added focus trap to dropdown * fix: fixed focus style in navbar * fix: fixed navigation keys in dropdown * fix: fixed versions dropdown * fix: reuse dropdown for versions * feat: search adjustments (#3819) * ktl-1608 feat: search adjustments * fix: fixed focus style for search button --------- Co-authored-by: Yuri Teplyakov <[email protected]> * fix: fix icons blinking * ktl-1608 feat: search style fixes (#3840) * feat: implemented new button states * ktl-1608 feat: style fixes * ktl-1608 feat: fix clear button * fixes after rebase --------- Co-authored-by: berezinant <[email protected]> * ktl-1608 feat: test review fixes (#3879) * ktl-1332 fix: fix styles overlap and add max and min values (#3909) * ktl-1711 feat: style bundle optimization (#3905) * feat: reworked ToC according to new design (#3841) * feat: implemented new button states * feat: reworked ToC appearance * fix: moved images to assets * fix: fix toc interactivity * fix: fixed problem with hover on touch screens * fix: open toc no mobile * fix scripts loading in safari * fix: fixed overlap of dropdown with toc on desktop * fix: fixed closing toc on mobile * fix: versions dropdown position * fix: version selector position * fix: logo customization fix * fix: made version selector compatible with old versions * fix: added limit to platform tags * fix: min width for dropdown and padding for toc * fix toc width * ktl-1735 feat: fix platform z-index in safari (#3927) * fix: proper dropdown width * test: updated navigation tests * ktl-1727 fix: fix safari flickering (#3929) * ktl-1727 fix: fix safari flickering * ktl-1737 fix: fix version capitalization * fix: fix tabs init * ktl-1737 fix: capitalize only first letter (#3931) * fix: platform filtering in multimodule * ktl-1758 fix: fix filter notification duplication (#3932) * test: update expected results for html tests (#3928) * ktl-1766 fix: fix header styles (#3940) --------- Co-authored-by: Yuri Teplyakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some states for demo:
