Throw connection issue immediately hub4j#159

KostyaSha · Mar 3, 2015 · c4faa73 · c4faa73
1 parent 0bf81f4
commit c4faa73
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/main/java/org/kohsuke/github/Requester.java b/src/main/java/org/kohsuke/github/Requester.java
@@ -421,15 +421,18 @@ private InputStream wrapStream(HttpURLConnection uc, InputStream in) throws IOEx
      * Otherwise throw an exception reporting an error.
      */
     /*package*/ void handleApiError(IOException e, HttpURLConnection uc) throws IOException {
-        if ("0".equals(uc.getHeaderField("X-RateLimit-Remaining"))) {
-            // API limit reached. wait 10 secs and return normally
-            try {
-                Thread.sleep(10000);
-                return;
-            } catch (InterruptedException _) {
-                throw (InterruptedIOException)new InterruptedIOException().initCause(e);
-            }
-        }
+        // Disable this check, because it causes "infinite" thread usage when:
+        // 1) set bad password you can't apply changed without interrupting thread
+        // 2) exhausted limit will cause lock upto 1h until reset time
+//        if ("0".equals(uc.getHeaderField("X-RateLimit-Remaining"))) {
+//            // API limit reached. wait 10 secs and return normally
+//            try {
+//                Thread.sleep(10000);
+//                return;
+//            } catch (InterruptedException _) {
+//                throw (InterruptedIOException)new InterruptedIOException().initCause(e);
+//            }
+//        }
 
         if (e instanceof FileNotFoundException)
             throw e;    // pass through 404 Not Found to allow the caller to handle it intelligently