New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinite Thread usage loop with handleApiError #159

Closed

KostyaSha opened this issue Mar 2, 2015 · 1 comment

Contributor

KostyaSha commented Mar 2, 2015

https://github.com/kohsuke/github-api/blob/4b6981c2e7e60a510d5881e33f850aafa5bad25d/src/main/java/org/kohsuke/github/Requester.java#L191-L222
+
https://github.com/kohsuke/github-api/blob/4b6981c2e7e60a510d5881e33f850aafa5bad25d/src/main/java/org/kohsuke/github/Requester.java#L423-L428
ends with infinite loop that may lock all jenkins Timers

Contributor Author

KostyaSha commented Mar 2, 2015

@kohsuke is there any way to raise this exception instead of looping, because jenkins cron will redo this check in next time itself?

KostyaSha added a commit to KostyaSha/github-api that referenced this issue


          Throw connection issue immediately hub4j#159

c4faa73

KostyaSha mentioned this issue

Rate-Limit: Thread fix, reset date #160

Closed

KostyaSha added a commit to KostyaSha/github-api that referenced this issue


          Throw connection issue immediately hub4j#159

2f9c321

KostyaSha closed this as completed

This was referenced Mar 17, 2015

Add logging of requests and responses #151

Closed

Rate limiting causes silent freezing failures #172

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment