Refactor first-person mode and configuration logic in ModifierLayer class #120
Conversation
- Introduced `getFirstPersonModifierOrDefault()` method to encapsulate the logic for retrieving the highest-priority modifier, prioritizing `FirstPersonModifier` instances. - Updated `getFirstPersonMode(float tickDelta)` to delegate the retrieval of modifiers and animations more cleanly. - Updated `getFirstPersonConfiguration(float tickDelta)` with a similar streamlined logic. - Added detailed Javadoc comments to explain the behavior and logic of the methods: - `getFirstPersonMode(float tickDelta)` - `getFirstPersonConfiguration(float tickDelta)` - `getFirstPersonModifierOrDefault()` - Improved code readability, modularity, and maintainability by reducing duplication and clarifying method responsibilities. This refactoring ensures greater clarity for future developers and prepares the code base for possible extensions, as well as prioritizing the newly created FirstPersonModifier.
|
Well now I have modified a little bit the code that decides which configuration to use with priority giving it to FirstPersonModifier if it is present as I commented in the other pull request |
RazorPlay01
changed the title
|
You sent a pr where you added a new modifier but then it turned out to be overridden by a different animation and you decided to submit a more delusional pr? You can override these methods in your container and it will be a more reliable option |
|
I know, but this is a more practical and easier way to use. |
|
I don't oppose this PR as long as it doesn't make any API breaking changes (Which it seems to currently do, take a look at my review) |
|
It shouldn't break anything as it respects how it was done before as long as the new modifier is not used |
|
Oh right, I didn't pay close enough attention. |
getFirstPersonModifierOrDefault()method to encapsulate the logic for retrieving the highest-priority modifier, prioritizingFirstPersonModifierinstances.getFirstPersonMode(float tickDelta)to delegate the retrieval of modifiers and animations more cleanly.getFirstPersonConfiguration(float tickDelta)with a similar streamlined logic.getFirstPersonMode(float tickDelta)getFirstPersonConfiguration(float tickDelta)getFirstPersonModifierOrDefault()This refactoring ensures greater clarity for future developers and prepares the code base for possible extensions, as well as prioritizing the newly created FirstPersonModifier.