Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source to QueryReferenceRewrite #783

Open
margaretha opened this issue Nov 27, 2024 · 1 comment
Open

Add source to QueryReferenceRewrite #783

margaretha opened this issue Nov 27, 2024 · 1 comment
Milestone

Comments

@margaretha
Copy link
Contributor

QueryReferenceRewrite rewrites a reference to a stored query, e.g.

{
  "ref" : "dory/dory-q",
  "@type" : "koral:queryRef"
}

is rewritten into

{
  "@type" : "koral:token",
  "rewrites" : [ {
    "@type" : "koral:rewrite",
    "src" : "Kustvakt",
    "origin" : "Kustvakt",
    "operation" : "operation:deletion",
    "scope" : "@type(koral:queryRef)"
  }, {
    "@type" : "koral:rewrite",
    "src" : "Kustvakt",
    "origin" : "Kustvakt",
    "operation" : "operation:deletion",
    "scope" : "ref(dory/dory-q)"
  }, {
    "@type" : "koral:rewrite",
    "src" : "Kustvakt",
    "origin" : "Kustvakt",
    "operation" : "operation:injection"
  } ]
}

The scope should be updated and source should be added as follows

{
  "@type" : "koral:token",
  "rewrites" : [ {
    "@type" : "koral:rewrite",
    "src" : "Kustvakt",
    "origin" : "Kustvakt",
    "operation" : "operation:deletion",
    "scope" : "@type",
    "source" : "koral:queryRef"
  }, {
    "@type" : "koral:rewrite",
    "src" : "Kustvakt",
    "origin" : "Kustvakt",
    "operation" : "operation:deletion",
    "scope" : "ref",
    "source" : "dory/dory-q"
  }, 
  ...
 ]
}
idsgerrit pushed a commit that referenced this issue Dec 3, 2024
Update VirtualCorpusRewrite Remove Owner (#779)
Add source to QueryReferenceRewrite (#783) and VirtualCorpusRewrite
(#780)

Change-Id: I53fbae553758d8319d9438afe761f3cc7299cdd0
@margaretha margaretha added this to the 0.76 milestone Dec 3, 2024
@margaretha
Copy link
Contributor Author

To be coherent with VirtualCorpus(Reference)Rewrite, operation:override should also be used in QueryReferenceRewrite instead of deletion and injection.

idsgerrit pushed a commit that referenced this issue Dec 4, 2024
Change-Id: Iaaaefcb325a4062fac7ef0e8adc243ffa70f5e95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant