Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VirtualCorpusRewrite Remove Owner #779

Closed
margaretha opened this issue Nov 25, 2024 · 3 comments
Closed

Update VirtualCorpusRewrite Remove Owner #779

margaretha opened this issue Nov 25, 2024 · 3 comments
Milestone

Comments

@margaretha
Copy link
Contributor

margaretha commented Nov 25, 2024

Named virtual corpora are system corpora that are cached by filenames.

When searching a named VC with a username, for instance:

referTo "system/ratskorpus"

Kustvakt rewrites the query as follows

{
    "@type": "koral:docGroupRef",
    "ref": "ratskorpus",
    "rewrites": [
        {
            "@type": "koral:rewrite",
            "operation": "operation:deletion",
            "scope": "ref(system/ratskorpus)",
            "src": "Kustvakt"
        },
        {
            "@type": "koral:rewrite",
            "operation": "operation:insertion",
            "scope": "ref(ratskorpus)",
            "src": "Kustvakt"
        }
    ]
}

The rewrites should be merged with operation:override.

{
  "@type" : "koral:rewrite",
  "src" : "Kustvakt",
  "origin" : "Kustvakt",
  "operation" : "operation:override",
  "scope" : "ref",
  "source" : "system/ratskorpus"
}

For the future, the cache keys should be enhanced with username instead, so we can support caching users VC as well.

@margaretha margaretha added this to the 0.76 milestone Nov 25, 2024
@Akron
Copy link
Member

Akron commented Nov 28, 2024

Sounds reasonable. I guess you mean system/ratskorpus instead of system/named-vc1 in the last snippet.

@margaretha
Copy link
Contributor Author

Yes, I have updated the issue description.

idsgerrit pushed a commit that referenced this issue Dec 3, 2024
Update VirtualCorpusRewrite Remove Owner (#779)
Add source to QueryReferenceRewrite (#783) and VirtualCorpusRewrite
(#780)

Change-Id: I53fbae553758d8319d9438afe761f3cc7299cdd0
@margaretha
Copy link
Contributor Author

I have added a new issue #784 to remind us about the improvement of VC-cache structure with usernames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants