Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isValidating true when key is falsey #195

Closed
klaemo opened this issue Jun 9, 2021 · 0 comments · Fixed by #205
Closed

isValidating true when key is falsey #195

klaemo opened this issue Jun 9, 2021 · 0 comments · Fixed by #205
Labels
bug Something isn't working

Comments

@klaemo
Copy link

klaemo commented Jun 9, 2021

Hey there,

it seems like the isValidating flag is true even if no request is currently happening (or has happened). This feels like a bug.

const { isValidating } = useSWRV(() => null)

// `isValidating` is `true` even though no fetch is happening

Thank you!
@darrenjennings darrenjennings added the bug Something isn't working label Jun 29, 2021
darrenjennings added a commit that referenced this issue Jun 29, 2021
@darrenjennings
fix(isValidating): add nullish check when no key
65b2300 
Fixes #195
darrenjennings added a commit that referenced this issue Jun 29, 2021
@darrenjennings
fix(isValidating): add nullish check when no key
1f0bf5f 
Fixes #195
darrenjennings added a commit that referenced this issue Jun 29, 2021
@darrenjennings
fix(isValidating): add nullish check when no key
9384ff2 
Fixes #195
darrenjennings added a commit that referenced this issue Jun 29, 2021
@darrenjennings
fix(isValidating): add nullish check when no key
5143e94 
Fixes #195
@darrenjennings darrenjennings mentioned this issue Jun 29, 2021
Merged
darrenjennings added a commit that referenced this issue Jul 2, 2021
@darrenjennings
fix(isValidating): add nullish check when no key (#205)
2064807 
Fixes #195
darrenjennings added a commit that referenced this issue Mar 12, 2022
@darrenjennings
fix(isValidating): add nullish check when no key (#205)
4e97a16 
Fixes #195
adamdehaven pushed a commit that referenced this issue Aug 25, 2022
@darrenjennings @adamdehaven
fix(isValidating): add nullish check when no key (#205)
e696bb0 
Fixes #195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(isValidating): add nullish check when no key Kong/swrv
2 participants
@klaemo @darrenjennings