fix(isValidating): add nullish check when no key (#205)

Fixes #195
Kong · Mar 12, 2022 · 4e97a16 · 4e97a16
1 parent 314d8a1
commit 4e97a16
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/use-swrv.ts b/src/use-swrv.ts
@@ -388,6 +388,7 @@ function useSWRV<Data = any, Error = any> (...args): IResponse<Data, Error> {
     watch(keyRef, (val) => {
       keyRef.value = val
       stateRef.key = val
+      stateRef.isValidating = Boolean(val)
       setRefCache(keyRef.value, stateRef, ttl)
 
       if (!IS_SERVER && !isHydrated && keyRef.value) {

diff --git a/tests/use-swrv.spec.tsx b/tests/use-swrv.spec.tsx
@@ -688,6 +688,19 @@ describe('useSWRV - loading', () => {
     expect(wrapper.text()).toBe('hello, data, ready')
     done()
   })
+
+  // #195
+  it('should return loading state isValidating with nullish key', async done => {
+    const vm = new Vue(defineComponent({
+      template: `<div>{{ error }}:{{this.isValidating ? 'loading' : 'ready'}}</div>`,
+      setup () {
+        return useSWRV(() => null)
+      }
+    })).$mount()
+
+    expect(vm.$el.textContent).toBe(':ready')
+    done()
+  })
 })
 
 describe('useSWRV - mutate', () => {