Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kradio, kcheckbox): fix label alignment #2195

Merged
merged 1 commit into from
May 28, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented May 27, 2024

Summary

Fixed vertical alignment in KRadio and KCheckbox

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this May 27, 2024
@portikM portikM requested a review from a team as a code owner May 27, 2024 13:42
Copy link

netlify bot commented May 27, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 5033cf6
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66548dbc8aa484000852f3c6
😎 Deploy Preview https://deploy-preview-2195--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 5033cf6
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66548dbcfd9ca900087f28d6
😎 Deploy Preview https://deploy-preview-2195--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) May 27, 2024 13:44
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@portikM portikM merged commit cad802e into alpha May 28, 2024
9 checks passed
@portikM portikM deleted the fix/kradio-kcheckbox-label-alignment branch May 28, 2024 14:29
kongponents-bot pushed a commit that referenced this pull request May 28, 2024
# [9.0.0-alpha.161](v9.0.0-alpha.160...v9.0.0-alpha.161) (2024-05-28)

### Bug Fixes

* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([cad802e](cad802e))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.161 🎉

The release is available on:

Your semantic-release bot 📦🚀

adamdehaven pushed a commit that referenced this pull request Jun 3, 2024
# [9.0.0-alpha.161](v9.0.0-alpha.160...v9.0.0-alpha.161) (2024-05-28)

### Bug Fixes

* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([cad802e](cad802e))
adamdehaven pushed a commit that referenced this pull request Jun 3, 2024
# [9.0.0-alpha.161](v9.0.0-alpha.160...v9.0.0-alpha.161) (2024-05-28)

### Bug Fixes

* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([cad802e](cad802e))
adamdehaven pushed a commit that referenced this pull request Jun 15, 2024
# [9.0.0-alpha.161](v9.0.0-alpha.160...v9.0.0-alpha.161) (2024-05-28)

### Bug Fixes

* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([cad802e](cad802e))
kongponents-bot pushed a commit that referenced this pull request Jun 15, 2024
# [9.0.0-alpha.102](v9.0.0-alpha.101...v9.0.0-alpha.102) (2024-06-15)

### Bug Fixes

* add question marks before tostring [KHCP-12065] ([#2200](#2200)) ([4b0ab0d](4b0ab0d))
* **datetimepicker:** no border needed around kbutton [MA-2582] ([#2002](#2002)) ([e0ada36](e0ada36))
* **deps:** update all non-major dependencies with stable version ([#2075](#2075)) ([afbd520](afbd520))
* **deps:** update dependency @kong/icons to ^1.8.15 ([#2107](#2107)) ([151e73c](151e73c))
* **deps:** update dependency @kong/icons to ^1.8.16 ([#2120](#2120)) ([302ab97](302ab97))
* **deps:** update dependency @kong/icons to ^1.9.0 ([#2144](#2144)) ([98ea80d](98ea80d))
* **deps:** update dependency @kong/icons to ^1.9.1 ([#2155](#2155)) ([fe204a7](fe204a7))
* **deps:** update dependency @kong/icons to ^1.9.2 ([#2194](#2194)) ([7adc31e](7adc31e))
* **docs:** deploy ([b7e330f](b7e330f))
* export components object ([#1999](#1999)) ([5a20aae](5a20aae))
* **kalert,kemptystate:** icon slot test ([#2123](#2123)) ([d394d7d](d394d7d))
* **kbadge, kcopy:** minor fix ([#2218](#2218)) ([6f2cb0a](6f2cb0a))
* **kbutton:** remove deprecated icon slot ([#2215](#2215)) ([0b31480](0b31480))
* **kcard:** add title tag prop ([#2069](#2069)) ([5ee7015](5ee7015))
* **kcard:** title font size ([#2074](#2074)) ([cbfd7f7](cbfd7f7))
* **KCodeBlock:** add question marks [KHCP-11554] ([#2142](#2142)) ([aab9c58](aab9c58))
* **kcodeblock:** fix shortcut manager runtime undefined ([#2126](#2126)) ([73873ff](73873ff))
* **kcodeblock:** misc fixes ([#2045](#2045)) ([fc5c196](fc5c196))
* **kcollapse:** add title slot ([#2174](#2174)) ([c78e877](c78e877))
* **kcopy:** icon & tooltip text styles ([#2050](#2050)) ([1533d15](1533d15))
* **kcopy:** not using actual button ([#2113](#2113)) ([c42eb1d](c42eb1d))
* **kcopy:** substring of undefined [KHCP-11057] ([#2061](#2061)) ([110ed39](110ed39))
* **kdropdown:** close on popover click ([#2224](#2224)) ([c9203a9](c9203a9))
* **kdropdown:** fix leaking styles ([#2221](#2221)) ([cb8a573](cb8a573))
* **kdropdown:** update dropdown popover selector ([#2225](#2225)) ([4b1599f](4b1599f))
* **kfileupload:** force transparent color for the input element ([#2177](#2177)) ([79169c9](79169c9))
* **kinput:** add aria label to associate helper text with input [KHCP-11030] ([#2138](#2138)) ([c287675](c287675))
* **kinput:** update classes ([#2182](#2182)) ([2c34d8d](2c34d8d))
* **kinput:** update readonly styles [KHCP-10785] ([#2027](#2027)) ([4044616](4044616))
* **klabel, kselect, kmultiselect:** a11y attributes [KHCP-111026] ([#2077](#2077)) ([a558015](a558015))
* **kmodal:** add input autofocus prop [KHCP-11113] ([#2073](#2073)) ([b26170d](b26170d))
* **kmodal:** remove enforcing title icon color ([#2068](#2068)) ([386e80a](386e80a))
* **kmodal:** toggle focus trap off on unmounted ([#2081](#2081)) ([1e7c660](1e7c660))
* **kmultiselect:** react to resize [KHCP-10321] ([#2039](#2039)) ([74f2b61](74f2b61))
* **kprompt:** add arial-label ([#2102](#2102)) ([566ddc4](566ddc4))
* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([e2bad75](e2bad75))
* **kradio, kcheckbox:** required field indicator [KHCP-11503] ([#2159](#2159)) ([10e6533](10e6533))
* **kselect:** avoid incorrect event triggering with null ([#2168](#2168)) ([6775875](6775875))
* **kselect:** fix double emits bug ([#2156](#2156)) ([844fc9d](844fc9d))
* **kselect:** invisible user input [KHCP-11152] ([#2076](#2076)) ([de869d9](de869d9))
* **kslideout:** remove user-select: none from title of KSlideout ([#2080](#2080)) ([d095dd8](d095dd8))
* **ktable:** column visibility design feedback ([#2152](#2152)) ([bcd4ded](bcd4ded))
* **ktable:** column visibility menu button ([#2136](#2136)) ([1ec6a99](1ec6a99))
* **ktable:** dont clear visibility prefs on load ([#2131](#2131)) ([ce4f4c6](ce4f4c6))
* **ktable:** emit preferences only in success state [KHCP-11890] ([#2191](#2191)) ([10ff5ae](10ff5ae))
* **ktable:** init col visibility [khcp-11730] ([#2169](#2169)) ([e87426e](e87426e))
* **ktable:** resized column choppiness ([#2139](#2139)) ([76ad562](76ad562))
* **ktabs:** disabled item remove pointer events none [KHCP-11265] ([#2103](#2103)) ([fd78db6](fd78db6))
* **ktooltip:** keep tiooltip open on content hover ([#2044](#2044)) ([ae0d72d](ae0d72d))
* **ktooltip:** suppress vue attr passthrough warning ([#2178](#2178)) ([b9630ce](b9630ce))
* **ktreelist:** label alignment ([#2128](#2128)) ([6c08b87](6c08b87))
* misc alpha fixes ([#2207](#2207)) ([9d2095e](9d2095e))
* rebase alpha commits to fix invalid commit messages ([#2201](#2201)) ([50a4227](50a4227)), closes [#1995](#1995) [#1994](#1994) [#1993](#1993) [#1990](#1990) [#1991](#1991) [#1997](#1997) [#1999](#1999) [#1999](#1999) [#2001](#2001) [#2001](#2001) [#2002](#2002) [#2002](#2002) [#2004](#2004) [#2007](#2007) [#2006](#2006) [#2010](#2010) [#1963](#1963) [#2003](#2003) [#1989](#1989) [#1998](#1998) [#1988](#1988)
* release tags ([92143a4](92143a4))
* release tags ([4ff3bd8](4ff3bd8))
* **ShortcutManager:** return empty string for invalid keycode during normalization [KHCP-11186] ([#2137](#2137)) ([7b10359](7b10359))
* **styles:** remove tmp variables, old mixins [KHCP-8944] ([#2181](#2181)) ([e593330](e593330))
* tags ([69b52d3](69b52d3))
* tags ([4357467](4357467))
* tags ([#2158](#2158)) ([5df026f](5df026f))
* trigger release ([1c84e87](1c84e87))
* trigger release ([ee189e2](ee189e2))
* trigger release ([6e8c3cd](6e8c3cd))
* **ts:** add danger property to dropdown item interface ([#2001](#2001)) ([db8e4cb](db8e4cb))
* **types:** allow legend header tag ([#2129](#2129)) ([68ab464](68ab464))
* **types:** module needs an export ([#2223](#2223)) ([8c53a2e](8c53a2e))
* using icons as buttons ([#2119](#2119)) ([3eb7c06](3eb7c06))

### Features

* add zIndex prop to overlaying components [KHCP-10747] ([#2130](#2130)) ([b7c1738](b7c1738))
* **eslint:** eslint v9 and shared configs [KHCP-11627] ([#2209](#2209)) ([3ab1ac2](3ab1ac2))
* **kalert, kemptystate, kpagination, kviewswitcher:** component reskin ([#2043](#2043)) ([f3f1e78](f3f1e78)), closes [#2030](#2030) [#2021](#2021)
* **kcatalogitem:** add card-footer slot ([#2154](#2154)) ([9bdcbc9](9bdcbc9))
* **kcodeblock, kcatalog, kcollapse, kstepper:** components reskin ([#2124](#2124)) ([5d7f7d0](5d7f7d0)), closes [#2100](#2100) [#2125](#2125)
* **kcopy:** support truncationLimit auto [khcp-11256] ([#2106](#2106)) ([6c3db4b](6c3db4b))
* **kicon:** remove component [KHCP-8983] ([#2183](#2183)) ([3294326](3294326))
* **kinline edit:** remove component [KHCP-8984] ([#2049](#2049)) ([9a625af](9a625af))
* **kpop:** component reskin [KHCP-8994] ([#2176](#2176)) ([a41a056](a41a056))
* **kpop:** refactor using floating ui [KHCP-11957] ([#2204](#2204)) ([222bde0](222bde0))
* **ktable:** add column resize support [khcp-11161] ([#2105](#2105)) ([cbbb3b5](cbbb3b5))
* **ktable:** component reskin [KHCP-9002] ([#2151](#2151)) ([c64a505](c64a505)), closes [#2144](#2144) [#2144](#2144) [#2145](#2145) [#2124](#2124) [#2100](#2100) [#2125](#2125)
* **ktable:** make visibility menu scrollable ([#2134](#2134)) ([7789ee5](7789ee5))
* **ktable:** toggle column visibility [khcp-11162] ([#2114](#2114)) ([6c706fd](6c706fd))
* **ktoaster:** refactor toastmanager [KHCP-11958] ([#2220](#2220)) ([74a2bba](74a2bba))
* **ktooltip, kdatetimepicker:** reskin components ([#2003](#2003)) ([21ad882](21ad882)), closes [#1989](#1989) [#1998](#1998) [#1988](#1988)
* **ktreelist, kbreadcrumb, kskeleton, kmenu:** component reskin ([#2097](#2097)) ([56bdd2b](56bdd2b)), closes [#2064](#2064) [#2051](#2051)
* **ktruncate, kslideout, ktoaster:** components reskin ([#2020](#2020)) ([ba9a265](ba9a265)), closes [#2009](#2009)
* ssr-friendlify components ([#2222](#2222)) ([f07cf61](f07cf61))
* switch from yarn to pnpm ([#2231](#2231)) ([9f846b7](9f846b7))
* trigger release maybe ([1b7655b](1b7655b))
* trigger release maybe ([7c40cd6](7c40cd6))
* trigger release maybe ([a2d5a2a](a2d5a2a))
kongponents-bot pushed a commit that referenced this pull request Jun 15, 2024
# [9.0.0-alpha.102](v9.0.0-alpha.101...v9.0.0-alpha.102) (2024-06-15)

### Bug Fixes

* add question marks before tostring [KHCP-12065] ([#2200](#2200)) ([4b0ab0d](4b0ab0d))
* **datetimepicker:** no border needed around kbutton [MA-2582] ([#2002](#2002)) ([e0ada36](e0ada36))
* **deps:** update all non-major dependencies with stable version ([#2075](#2075)) ([afbd520](afbd520))
* **deps:** update dependency @kong/icons to ^1.8.15 ([#2107](#2107)) ([151e73c](151e73c))
* **deps:** update dependency @kong/icons to ^1.8.16 ([#2120](#2120)) ([302ab97](302ab97))
* **deps:** update dependency @kong/icons to ^1.9.0 ([#2144](#2144)) ([98ea80d](98ea80d))
* **deps:** update dependency @kong/icons to ^1.9.1 ([#2155](#2155)) ([fe204a7](fe204a7))
* **deps:** update dependency @kong/icons to ^1.9.2 ([#2194](#2194)) ([7adc31e](7adc31e))
* **docs:** deploy ([b7e330f](b7e330f))
* export components object ([#1999](#1999)) ([5a20aae](5a20aae))
* **kalert,kemptystate:** icon slot test ([#2123](#2123)) ([d394d7d](d394d7d))
* **kbadge, kcopy:** minor fix ([#2218](#2218)) ([6f2cb0a](6f2cb0a))
* **kbutton:** remove deprecated icon slot ([#2215](#2215)) ([0b31480](0b31480))
* **kcard:** add title tag prop ([#2069](#2069)) ([5ee7015](5ee7015))
* **kcard:** title font size ([#2074](#2074)) ([cbfd7f7](cbfd7f7))
* **KCodeBlock:** add question marks [KHCP-11554] ([#2142](#2142)) ([aab9c58](aab9c58))
* **kcodeblock:** fix shortcut manager runtime undefined ([#2126](#2126)) ([73873ff](73873ff))
* **kcodeblock:** misc fixes ([#2045](#2045)) ([fc5c196](fc5c196))
* **kcollapse:** add title slot ([#2174](#2174)) ([c78e877](c78e877))
* **kcopy:** icon & tooltip text styles ([#2050](#2050)) ([1533d15](1533d15))
* **kcopy:** not using actual button ([#2113](#2113)) ([c42eb1d](c42eb1d))
* **kcopy:** substring of undefined [KHCP-11057] ([#2061](#2061)) ([110ed39](110ed39))
* **kdropdown:** close on popover click ([#2224](#2224)) ([c9203a9](c9203a9))
* **kdropdown:** fix leaking styles ([#2221](#2221)) ([cb8a573](cb8a573))
* **kdropdown:** update dropdown popover selector ([#2225](#2225)) ([4b1599f](4b1599f))
* **kfileupload:** force transparent color for the input element ([#2177](#2177)) ([79169c9](79169c9))
* **kinput:** add aria label to associate helper text with input [KHCP-11030] ([#2138](#2138)) ([c287675](c287675))
* **kinput:** update classes ([#2182](#2182)) ([2c34d8d](2c34d8d))
* **kinput:** update readonly styles [KHCP-10785] ([#2027](#2027)) ([4044616](4044616))
* **klabel, kselect, kmultiselect:** a11y attributes [KHCP-111026] ([#2077](#2077)) ([a558015](a558015))
* **kmodal:** add input autofocus prop [KHCP-11113] ([#2073](#2073)) ([b26170d](b26170d))
* **kmodal:** remove enforcing title icon color ([#2068](#2068)) ([386e80a](386e80a))
* **kmodal:** toggle focus trap off on unmounted ([#2081](#2081)) ([1e7c660](1e7c660))
* **kmultiselect:** react to resize [KHCP-10321] ([#2039](#2039)) ([74f2b61](74f2b61))
* **kprompt:** add arial-label ([#2102](#2102)) ([566ddc4](566ddc4))
* **kradio, kcheckbox:** fix label alignment ([#2195](#2195)) ([e2bad75](e2bad75))
* **kradio, kcheckbox:** required field indicator [KHCP-11503] ([#2159](#2159)) ([10e6533](10e6533))
* **kselect:** avoid incorrect event triggering with null ([#2168](#2168)) ([6775875](6775875))
* **kselect:** fix double emits bug ([#2156](#2156)) ([844fc9d](844fc9d))
* **kselect:** invisible user input [KHCP-11152] ([#2076](#2076)) ([de869d9](de869d9))
* **kslideout:** remove user-select: none from title of KSlideout ([#2080](#2080)) ([d095dd8](d095dd8))
* **ktable:** column visibility design feedback ([#2152](#2152)) ([bcd4ded](bcd4ded))
* **ktable:** column visibility menu button ([#2136](#2136)) ([1ec6a99](1ec6a99))
* **ktable:** dont clear visibility prefs on load ([#2131](#2131)) ([ce4f4c6](ce4f4c6))
* **ktable:** emit preferences only in success state [KHCP-11890] ([#2191](#2191)) ([10ff5ae](10ff5ae))
* **ktable:** init col visibility [khcp-11730] ([#2169](#2169)) ([e87426e](e87426e))
* **ktable:** resized column choppiness ([#2139](#2139)) ([76ad562](76ad562))
* **ktabs:** disabled item remove pointer events none [KHCP-11265] ([#2103](#2103)) ([fd78db6](fd78db6))
* **ktooltip:** keep tiooltip open on content hover ([#2044](#2044)) ([ae0d72d](ae0d72d))
* **ktooltip:** suppress vue attr passthrough warning ([#2178](#2178)) ([b9630ce](b9630ce))
* **ktreelist:** label alignment ([#2128](#2128)) ([6c08b87](6c08b87))
* misc alpha fixes ([#2207](#2207)) ([9d2095e](9d2095e))
* rebase alpha commits to fix invalid commit messages ([#2201](#2201)) ([50a4227](50a4227)), closes [#1995](#1995) [#1994](#1994) [#1993](#1993) [#1990](#1990) [#1991](#1991) [#1997](#1997) [#1999](#1999) [#1999](#1999) [#2001](#2001) [#2001](#2001) [#2002](#2002) [#2002](#2002) [#2004](#2004) [#2007](#2007) [#2006](#2006) [#2010](#2010) [#1963](#1963) [#2003](#2003) [#1989](#1989) [#1998](#1998) [#1988](#1988)
* release tags ([92143a4](92143a4))
* release tags ([4ff3bd8](4ff3bd8))
* **ShortcutManager:** return empty string for invalid keycode during normalization [KHCP-11186] ([#2137](#2137)) ([7b10359](7b10359))
* **styles:** remove tmp variables, old mixins [KHCP-8944] ([#2181](#2181)) ([e593330](e593330))
* tags ([69b52d3](69b52d3))
* tags ([4357467](4357467))
* tags ([#2158](#2158)) ([5df026f](5df026f))
* trigger release ([1c84e87](1c84e87))
* trigger release ([ee189e2](ee189e2))
* trigger release ([6e8c3cd](6e8c3cd))
* **ts:** add danger property to dropdown item interface ([#2001](#2001)) ([db8e4cb](db8e4cb))
* **types:** allow legend header tag ([#2129](#2129)) ([68ab464](68ab464))
* **types:** module needs an export ([#2223](#2223)) ([8c53a2e](8c53a2e))
* using icons as buttons ([#2119](#2119)) ([3eb7c06](3eb7c06))

### Features

* add zIndex prop to overlaying components [KHCP-10747] ([#2130](#2130)) ([b7c1738](b7c1738))
* **eslint:** eslint v9 and shared configs [KHCP-11627] ([#2209](#2209)) ([3ab1ac2](3ab1ac2))
* **kalert, kemptystate, kpagination, kviewswitcher:** component reskin ([#2043](#2043)) ([f3f1e78](f3f1e78)), closes [#2030](#2030) [#2021](#2021)
* **kcatalogitem:** add card-footer slot ([#2154](#2154)) ([9bdcbc9](9bdcbc9))
* **kcodeblock, kcatalog, kcollapse, kstepper:** components reskin ([#2124](#2124)) ([5d7f7d0](5d7f7d0)), closes [#2100](#2100) [#2125](#2125)
* **kcopy:** support truncationLimit auto [khcp-11256] ([#2106](#2106)) ([6c3db4b](6c3db4b))
* **kicon:** remove component [KHCP-8983] ([#2183](#2183)) ([3294326](3294326))
* **kinline edit:** remove component [KHCP-8984] ([#2049](#2049)) ([9a625af](9a625af))
* **kpop:** component reskin [KHCP-8994] ([#2176](#2176)) ([a41a056](a41a056))
* **kpop:** refactor using floating ui [KHCP-11957] ([#2204](#2204)) ([222bde0](222bde0))
* **ktable:** add column resize support [khcp-11161] ([#2105](#2105)) ([cbbb3b5](cbbb3b5))
* **ktable:** component reskin [KHCP-9002] ([#2151](#2151)) ([c64a505](c64a505)), closes [#2144](#2144) [#2144](#2144) [#2145](#2145) [#2124](#2124) [#2100](#2100) [#2125](#2125)
* **ktable:** make visibility menu scrollable ([#2134](#2134)) ([7789ee5](7789ee5))
* **ktable:** toggle column visibility [khcp-11162] ([#2114](#2114)) ([6c706fd](6c706fd))
* **ktoaster:** refactor toastmanager [KHCP-11958] ([#2220](#2220)) ([74a2bba](74a2bba))
* **ktooltip, kdatetimepicker:** reskin components ([#2003](#2003)) ([21ad882](21ad882)), closes [#1989](#1989) [#1998](#1998) [#1988](#1988)
* **ktreelist, kbreadcrumb, kskeleton, kmenu:** component reskin ([#2097](#2097)) ([56bdd2b](56bdd2b)), closes [#2064](#2064) [#2051](#2051)
* **ktruncate, kslideout, ktoaster:** components reskin ([#2020](#2020)) ([ba9a265](ba9a265)), closes [#2009](#2009)
* ssr-friendlify components ([#2222](#2222)) ([f07cf61](f07cf61))
* switch from yarn to pnpm ([#2231](#2231)) ([9f846b7](9f846b7))
* trigger release maybe ([1b7655b](1b7655b))
* trigger release maybe ([7c40cd6](7c40cd6))
* trigger release maybe ([a2d5a2a](a2d5a2a))

### Reverts

* bad release for dep update ([5a8e287](5a8e287))
* update dependency @kong-ui-public/sandbox-layout to ^2.1.6 ([a090d60](a090d60))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants