fix(kdropdown): close on popover click (#2224)

Kong · Jun 15, 2024 · c9203a9 · c9203a9
1 parent 8dbdc8a
commit c9203a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/sandbox/pages/SandboxDropdown.vue b/sandbox/pages/SandboxDropdown.vue
@@ -223,7 +223,7 @@
           trigger-text="Slotted content positioning"
           width="250"
         >
-          <template #items>
+          <template #items="{ closeDropdown }">
             <KDropdownItem>
               Updates
               <KBadge
@@ -233,15 +233,19 @@
                 14
               </KBadge>
             </KDropdownItem>
-            <KDropdownItem>
+            <KDropdownItem @click="handleItemClick">
               Support
               <KBadge
                 appearance="success"
                 shape="rectangular"
               >
                 Enterprise
               </KBadge>
-              <ExternalLinkIcon class="dropdown-item-content-end" />
+              <KExternalLink
+                class="dropdown-item-content-end"
+                href="https://kongponents.konghq.com/"
+                @click.stop="closeDropdown"
+              />
             </KDropdownItem>
             <KDropdownItem>
               <BookIcon />

diff --git a/src/components/KDropdown/KDropdown.vue b/src/components/KDropdown/KDropdown.vue
@@ -7,7 +7,7 @@
       <KPop
         ref="kPop"
         v-bind="boundKPopAttributes"
-        :close-on-popover-click="!isToggled.value"
+        close-on-popover-click
         data-testid="k-dropdown-popover"
         hide-close-icon
         @close="() => handleTriggerToggle(isToggled, toggle, false)"