Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate plugin PRIORITY and VERSION fields upon loading #8836

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented May 20, 2022

Adds stricter checks on plugins when loading. Priority must be a valid integer (not inf nor NaN), and the version must be parseble as x.y.z.

This means the pre-functions plugin now has a PRIORITY = 1000000, which previously was +inf.

review: best reviewed without whitespace changes

kong/db/dao/plugins.lua Outdated Show resolved Hide resolved
@fffonion
Copy link
Contributor

@Tieske Does this mean all external plugins needs to have Version and Priority defined?

@Tieske
Copy link
Member Author

Tieske commented May 31, 2022

Does this mean all external plugins needs to have Version and Priority defined?

Yes, so it's a breaking change. But it's for the better imho since it allows for better control of plugins, they should have it anyway. Only thus far they got away without it.

@Tieske Tieske force-pushed the force-priority branch 2 times, most recently from 6c14b55 to c53e3c7 Compare June 3, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants