-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate plugin PRIORITY and VERSION fields upon loading #8836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog
chore
Not part of the core functionality of kong, but still needed
core/admin-api
core/cli
core/clustering
core/db
core/docs
core/language/go
core/language/js
core/language/python
core/pdk
core/proxy
plugins/acme
plugins/aws-lambda
plugins/cors
plugins/datadog
plugins/oauth2
plugins/prometheus
plugins/rate-limiting
plugins/response-ratelimiting
plugins/serverless-functions
labels
May 20, 2022
Tieske
force-pushed
the
force-priority
branch
2 times, most recently
from
May 20, 2022 15:13
0a592a1
to
861a719
Compare
bungle
reviewed
May 21, 2022
@Tieske Does this mean all external plugins needs to have Version and Priority defined? |
Yes, so it's a breaking change. But it's for the better imho since it allows for better control of plugins, they should have it anyway. Only thus far they got away without it. |
Tieske
force-pushed
the
force-priority
branch
2 times, most recently
from
June 3, 2022 07:59
6c14b55
to
c53e3c7
Compare
bungle
approved these changes
Jun 3, 2022
This was referenced Oct 3, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stricter checks on plugins when loading. Priority must be a valid integer (not
inf
norNaN
), and the version must be parseble asx.y.z
.This means the
pre-functions
plugin now has aPRIORITY = 1000000
, which previously was+inf
.review: best reviewed without whitespace changes