add VERSION field #5199
Merged
add VERSION field #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins MUST now have a valid PRIORITY (integer) and VERSION (“x.y.z” format) field in their handler.lua file, otherwise the plugin will fail to load. #8836
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@yongxiaodong Hi! Thanks for making these updates! Do you have a link to the issue you mentioned (#8836)? I wasn't sure what repository that was in. Thanks! |
cloudjumpercat
added
the
review:general
|
@cloudjumpercat we can usually assume it's coming from the Kong/kong repo: Kong/kong#8836 |
lena-larionova
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Checked against the doc we have for Gateway, we already have it documented there: https://deploy-preview-5199--kongdocs.netlify.app/gateway/latest/plugin-development/custom-logic/
LGTM, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins MUST now have a valid PRIORITY (integer) and VERSION (“x.y.z” format) field in their handler.lua file, otherwise the plugin will fail to load. #8836