fix(declarative) initialize hash for empty config #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
shaneutt
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
From the KIC perspective all we're looking for is a data-point which indicates that the gateway has not been initialized with a configuration yet in DBLESS mode (primary reason being to trigger configuration re-push if the gateway container crashes). Having all 0's as an indicator of empty instead of null is workable for us 👍
flrgh
reviewed
Feb 18, 2022
| @@ -187,6 +187,7 @@ local constants = { | |||
| DECLARATIVE_PAGE_KEY = "declarative:page", | |||
| DECLARATIVE_LOAD_KEY = "declarative_config:loaded", | |||
| DECLARATIVE_HASH_KEY = "declarative_config:hash", | |||
| DECLARATIVE_EMPTY_CONFIG_HASH = string.rep("0", 32), | |||
There was a problem hiding this comment.
Nice! Good to see this moving to a constant rather than just being a magic string.
flrgh
approved these changes
Feb 18, 2022
locao
force-pushed
the
fix/empty_config_value
branch
from
be1a379
to
84bcea7
Compare
This was referenced Feb 18, 2022
kikito
pushed a commit
that referenced
this pull request
Feb 24, 2022
* fix(declarative) initialize hash for empty config * docs(CHANGELOG) feature description
kikito
pushed a commit
that referenced
this pull request
Feb 24, 2022
* fix(declarative) initialize hash for empty config * docs(CHANGELOG) feature description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds back the
configuration_hashentry to the/statusendpoint when using dbless mode/node is a dataplane and no configuration has been loaded.See #8214 for reference.
Full changelog
configuration_hashreturns"00000000000000000000000000000000"when no configuration has been loaded.FT-2358