-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration_hash in /status in dbless #8214
feat: add configuration_hash in /status in dbless #8214
Conversation
I tested this locally and it worked properly: I was able to verify that the hash and empty status message was populated only in However there was some kind of issue with the EDIT: well it ended up working in CI so perhaps it was a local environment issue? |
d416f7d
to
9b9bf79
Compare
Closing this in favor of #8256 |
@dndx suggested may still want this implementation for @Kong/team-k8s, re-opening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from an API perspective
1acca49
to
ed05a1d
Compare
2b699c0
to
54f5a16
Compare
54f5a16
to
859d81b
Compare
0aa7eb9
to
5f8b296
Compare
The code should add a test to assert that the hash is populated correctly on the Admin API /status endpoint as well (the code tests for Status API /status). |
f8e18cc
to
d4e27bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from an API perspective.
Someone in team gateway who has more familiarity with this code can review this further and approve.
Co-authored-by: Harry <[email protected]>
Co-authored-by: Harry <[email protected]>
Co-authored-by: Harry <[email protected]>
Merged! Thanks for pointing out, @RobSerafini 👍 |
Summary
In #8152 it was reported that if the Kong Gateway crashes the KIC will not be aware and unless something changes in the control plane, it will not push a new configuration.
This patch adds a
configuration_hash
to the/status
endpoint, which would help solve this problem (in DBLESS mode) by allowing the control-plane to keep track of changes to the hash on the data-plane and use that to make decisions about pushing new/config
updates.Issues resolved
Partially resolves Kong/kubernetes-ingress-controller#2107