fix: reused DAO sockets don't set the keyspace. fix #170 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAO sockets now take advantage of the connection pool and if they are coming from it (meaning they've been used before), they don't set their keyspace anymore.
|
I wrongfully closed #191 oops, recreating it here since GitHub doesn't let me reopen it. |
thibaultcha
added a commit
that referenced
this pull request
May 1, 2015
fix: reused DAO sockets don't set the keyspace. fix #170
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
fix: reused DAO sockets don't set the keyspace. fix Kong#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAO sockets now take advantage of the connection pool and if they are
coming from it (meaning they've been used before), they don't set their
keyspace anymore.