fix: reused DAO sockets don't set the keyspace. fix #170 #191
Conversation
DAO sockets now take advantage of the connection pool and if they are coming from it (meaning they've been used before), they don't set their keyspace anymore.
| return nil, DaoError(err, error_types.DATABASE) | ||
| end | ||
|
|
||
| if times == 0 or not times then |
There was a problem hiding this comment.
Not sure how lua works, but wouldn't you want to check for not times first?
There was a problem hiding this comment.
Oh yeah that's a legacy check, only the 0 is actually needed, thanks.
There was a problem hiding this comment.
Oops my bad, it was a still needed check. About the order, it is correct. Most of the time while in use, and in need of performance (when Kong will be running), get_reused_times() will return a number (0 possibly). And thus our first condition need to be that.
If we are in a phase of NGINX that doesn't support the cosocket API (init_by_lua) or maybe not even in the NGINX context (the DAO is also used by the CLI or by the unit tests), get_reused_times() can also error and return nil. That is a less common case and not in need of performance.
Hence why the check. My bad for thinking I could remove it, because I reorganized the code before pushing but overlooked at it. I closed this PR by mistake, and had to reopen it in #197 tho
DAO sockets now take advantage of the connection pool and if they are
coming from it (meaning they've been used before), they don't set their
keyspace anymore.