fix(kong.tools.http): ensure the EMPTY table returned by parse_directive_header is readonly
#13491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive_header` is readonly Panic on writing the EMPTY table
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
approved these changes
Aug 12, 2024
Water-Melon
approved these changes
Aug 12, 2024
|
Successfully created cherry-pick PR for |
3 tasks
ProBrian
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ective_header` is readonly (#13491) Panic on writing the EMPTY table * Fix #13458 * https://konghq.atlassian.net/browse/KAG-5139?
ADD-SP
pushed a commit
that referenced
this pull request
Aug 13, 2024
Inspired by #13491 This PR did not replace all so-called `EMPTY` tables, only which are obviously read-only. https://konghq.atlassian.net/browse/KAG-5140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Panic on writing the EMPTY table
Skipping changelog as this bug has not been released yet.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference