Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin): abstruct proxy cache related function to kong.tools #13458

Merged
merged 4 commits into from
Aug 7, 2024
Merged

refactor(plugin): abstruct proxy cache related function to kong.tools #13458

merged 4 commits into from
Aug 7, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Aug 6, 2024 •
edited
Loading

Summary

move proxy-cache plugin parse_directive_header and resource_ttl functions to kong tools for reuse in another plugin.

Checklist

Issue reference

AG-91

@github-actions github-actions bot added plugins/proxy-cache cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 6, 2024
@oowl oowl changed the title refactor(pkugin): abstruct proxy cache related function to kong.tools refactor(plugin): abstruct proxy cache related function to kong.tools Aug 6, 2024
fffonion
fffonion reviewed Aug 6, 2024
View reviewed changes
kong-3.8.0-0.rockspec Outdated Show resolved Hide resolved
@oowl oowl force-pushed the refactor-cache-tool branch 2 times, most recently from c454b14 to 938e213 Compare August 7, 2024 03:45
@fffonion fffonion merged commit dd37fac into master Aug 7, 2024
25 checks passed
@fffonion fffonion deleted the refactor-cache-tool branch August 7, 2024 07:37
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@ADD-SP ADD-SP mentioned this pull request Aug 12, 2024
Merged
ADD-SP added a commit that referenced this pull request Aug 12, 2024
@ADD-SP
fix(kong.tools.http): ensure the EMPTY table returned by `parse_dir…
0960f88 
…ective_header` is readonly (#13491)

Panic on writing the EMPTY table

* Fix #13458
* https://konghq.atlassian.net/browse/KAG-5139?
ProBrian pushed a commit that referenced this pull request Aug 13, 2024
@ADD-SP @ProBrian
fix(kong.tools.http): ensure the EMPTY table returned by `parse_dir…
4656717 
…ective_header` is readonly (#13491)

Panic on writing the EMPTY table

* Fix #13458
* https://konghq.atlassian.net/browse/KAG-5139?
oowl added a commit that referenced this pull request Aug 15, 2024
@oowl @fffonion
refactor(plugin): abstruct proxy cache related function to kong.tools (…
182056b 
…#13458)

move proxy-cache plugin parse_directive_header and resource_ttl functions to kong tools for reuse in another plugin.

AG-91

(cherry picked from commit dd37fac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liverpool8056 liverpool8056 liverpool8056 approved these changes

@fffonion fffonion fffonion approved these changes

Assignees

@oowl oowl

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/proxy-cache size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oowl @team-gateway-bot @fffonion @liverpool8056