[Backport release/3.2.x] fix(dbless): drain error table when flattening errors #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(dbless): drain error table when flattening errors This only affect `POST /config?flatten_errors=1`. When nested errors are flattened for the response body, they should be removed from the original error table so that they are not included in the final `fields` error object. Errors that are not flattened should remain. It could be argued that this is a backwards-incompatible change, but: 1. This is opt-in only via the `flatten_errors` query param. 2. It's arguably a behavioral fix since we are effectively de-duplicating the errors in the response. 3. This makes the response object much, much cleaner. * docs(changelog): update for #10256 (cherry picked from commit c550c11)
|
This PR interrupts CE2EE merge PR at https://github.com/Kong/kong-ee/actions/runs/4572521517/jobs/8109987680#step:11:2169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c550c11 from #10256.