fix(dbless): drain error table when flattening errors #10256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobSerafini This is a fix, but it's not really a blocker for anyone, so feel free to remove from the 3.2 milestone if we're too strapped for time. |
rainest
approved these changes
Feb 7, 2023
|
@tyler-ball - I leave it to you to decide the milestone question. |
|
This will need to wait; removed from milestone. |
|
|
This only affect `POST /config?flatten_errors=1`. When nested errors are flattened for the response body, they should be removed from the original error table so that they are not included in the final `fields` error object. Errors that are not flattened should remain. It could be argued that this is a backwards-incompatible change, but: 1. This is opt-in only via the `flatten_errors` query param. 2. It's arguably a behavioral fix since we are effectively de-duplicating the errors in the response. 3. This makes the response object much, much cleaner.
flrgh
force-pushed
the
fix/dbless-flattened-errors-drain
branch
from
fd9a6b0
to
66ff8a0
Compare
flrgh
force-pushed
the
fix/dbless-flattened-errors-drain
branch
from
66ff8a0
to
1763c7e
Compare
|
Changelog entry was added, and I've just rebased on master. This is good to go once CI is 🟢. |
team-gateway-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
* fix(dbless): drain error table when flattening errors This only affect `POST /config?flatten_errors=1`. When nested errors are flattened for the response body, they should be removed from the original error table so that they are not included in the final `fields` error object. Errors that are not flattened should remain. It could be argued that this is a backwards-incompatible change, but: 1. This is opt-in only via the `flatten_errors` query param. 2. It's arguably a behavioral fix since we are effectively de-duplicating the errors in the response. 3. This makes the response object much, much cleaner. * docs(changelog): update for #10256 (cherry picked from commit c550c11)
flrgh
added a commit
that referenced
this pull request
Mar 28, 2023
* fix(dbless): drain error table when flattening errors This only affect `POST /config?flatten_errors=1`. When nested errors are flattened for the response body, they should be removed from the original error table so that they are not included in the final `fields` error object. Errors that are not flattened should remain. It could be argued that this is a backwards-incompatible change, but: 1. This is opt-in only via the `flatten_errors` query param. 2. It's arguably a behavioral fix since we are effectively de-duplicating the errors in the response. 3. This makes the response object much, much cleaner. * docs(changelog): update for #10256 (cherry picked from commit c550c11) Co-authored-by: Michael Martin <[email protected]>
|
Does this need an explicit cherry pick from CE to EE? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affect
POST /config?flatten_errors=1.When nested errors are flattened for the response body, they should be removed from the original error table so that they are not included in the final
fieldserror object. Errors that are not flattened should remain.It could be argued that this is a backwards-incompatible change, but:
flatten_errorsquery param.flatten_errorsis a new, yet unreleased feature, there is no defined behavior to be broken.fieldsobject has not changed.