Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to preview PDF on Visual preview mode #325

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Ability to preview PDF on Visual preview mode #325

merged 1 commit into from
Jun 23, 2017

Conversation

Antoine38660
Copy link
Contributor

As discussed earlier here: #323

PDF Preview

screenshot from 2017-06-23 12 02 33

RAW view is still raw view:

screenshot from 2017-06-23 12 04 23

gschier
gschier approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, it's here already! Looks great, thanks!

Don't worry about the CI failures, I'll fix that. 😄

@gschier gschier merged commit 8fa948e into Kong:develop Jun 23, 2017
@gschier gschier mentioned this pull request Jun 23, 2017
Closed
@Antoine38660 Antoine38660 deleted the feature/pdf-preview branch June 23, 2017 20:44
@Antoine38660 Antoine38660 restored the feature/pdf-preview branch June 23, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschier gschier gschier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antoine38660 @gschier