Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Ability to preview PDF from the Preview Mode #323

Closed
Antoine38660 opened this issue Jun 22, 2017 · 4 comments
Closed

[Feature] Ability to preview PDF from the Preview Mode #323

Antoine38660 opened this issue Jun 22, 2017 · 4 comments

Comments

@Antoine38660
Copy link
Contributor

It would be useful to be able to preview a PDF file (Based on the Content-Type: application/pdf) directly inside the Preview Mode.

I read about pdf.js and Electron (but never tried to works with them) and it seems to be possible.

NB: I forked insomnia 2 days ago to try to contribute with this feature, but I’d like to know what you think of it before making a decision 😃
@gschier
Copy link
Contributor

gschier commented Jun 22, 2017

That would be an awesome addition. I would be hesitant if it required complex modifications or dependencies (like c++ addons), but pdf.js seems simple, safe, and easy 😄

Let me know if you have any questions along the way 👍

@gschier gschier changed the title [Feature Request] Ability to preview PDF from the Preview Mode [Feature] Ability to preview PDF from the Preview Mode Jun 22, 2017
Antoine38660 added a commit to Antoine38660/insomnia that referenced this issue Jun 23, 2017
@Antoine38660
Preview PDF on 'Visual preview mode' Kong#323
df56d3d
@Antoine38660 Antoine38660 mentioned this issue Jun 23, 2017
Merged
gschier pushed a commit that referenced this issue Jun 23, 2017
@Antoine38660 @gschier
Preview PDF on 'Visual preview mode' #323 (#325)
8fa948e
@gschier
Copy link
Contributor

gschier commented Jun 23, 2017

This was closed by #325

@gschier gschier closed this as completed Jun 23, 2017
@fabiomargarido fabiomargarido mentioned this issue Aug 30, 2017
Closed
@renanmorais
Copy link

its works ?

@Antoine38660
Copy link
Contributor Author

Yes it is

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gschier @renanmorais @Antoine38660