Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[digital-carbon] Clean up cco2 handler logic #189

Open
wants to merge 101 commits into
base: staging
Choose a base branch
from
Open

[digital-carbon] Clean up cco2 handler logic #189

wants to merge 101 commits into from

Conversation

psparacino
Copy link
Collaborator

@psparacino psparacino commented Sep 9, 2024 •
edited
Loading

📄 Description

Clean up redundant logic whenc creating cco2 Project entity

📝 Changelog

fix: clean up cco2 handler logic

✅ Checklist

  • Matchstick test included (if applicable).
  • Version incremented in package.json of the applicable subgraph(s)
  • All changes are reflected in the changelog of this PR for the applicable subgraph(s)

ℹ️ Additional Information

@psparacino psparacino changed the title ['digital-carbon`] Clean up cco2 handler logic [digital-carbon] Clean up cco2 handler logic Sep 9, 2024
0xAurelius
0xAurelius approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@0xAurelius 0xAurelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change itself seems fine but what's with this binary file? Should it maybe be in .gitignore to avoid conflicts?

@psparacino
Copy link
Collaborator Author

The code change itself seems fine but what's with this binary file? Should it maybe be in .gitignore to avoid conflicts?

Generated from the tests but yes, i'll gitignore them as they will recompile when they are in actions

@psparacino psparacino force-pushed the pdc/clean-up-cco2-handler branch from bb98a52 to c0c47fe Compare September 30, 2024 16:13
@psparacino psparacino changed the base branch from main to staging November 21, 2024 17:40
@psparacino
dev endpoint deploy action modification
aa05d4d
@psparacino
deploy-dev file with commit message naming
6bfbf4f
@psparacino
testing branch test
2c254dc
@psparacino
counter 1 [deploy carbonmark]
42bd285
@psparacino
remove testing variables
821eeda
@psparacino
revert to all dev deploymnets for all subgraphs
3ec9e63
@psparacino
testing branch setup
b306321
@psparacino
replace deprecated step name
bbcf4a2
@psparacino
remove testing branch name
e5212a0
@psparacino
add version.json for all subgraphs
b44c505
@psparacino
version script entity pipeline
29584dc
@psparacino
improve version injection script
1004c5f
@psparacino
ts-script setting version for blockHandler
0b8b5ef
@psparacino
all version entities set for all three subgraphs
b5cfdc0
@psparacino
updated manifests for blockHandler and schema version supporting bloc…
36e606a 
…kHandlers
@psparacino
add version scripts to subgraphs
f9e8e3d
@psparacino
check-version action
0ce2816
@psparacino
remove unneeded version.jsons
0acc80a
@psparacino
updated ci and check-version action
e2f4209
psparacino and others added 30 commits January 16, 2025 14:20
@psparacino
remove script key
c090ac0
@psparacino
update to node 18 for release and octokit
d3f8588
@psparacino
correct env name
53a8333
@psparacino
fix script for correct tag construction
aba21ba
@psparacino
add inital changelog entry if no lastTag and rename script
3e40f15
@psparacino
check last tag against zero version
e400c5e
@psparacino
repush after local testing and env cleanup
de6e58a
@psparacino
pass changelog back to github_output
810bf07
@psparacino
show error if commits exists but no changelog detected
8490741
@psparacino
clean up md and remove dev logging
809966a
@psparacino
add IS_MAIN variable for differentating deploy actions by branch
20f9403
@psparacino
address all requested revisions
ff7fe08
@psparacino
add more descriptive refactor+breaking change
076b52a
@psparacino
use env for staging check in staging or not
c882c52
@psparacino
deploy config fixes
02bfca1
@psparacino
testing fixes
3d5db1b
@psparacino
fix pdc version handler
b388c47
@psparacino
increment pdc version
a058afa
@psparacino
remove versioned subraphs
5240743
@psparacino
remove trailing parentheses
37482c0
@0xAurelius @psparacino
Add CMARK registry to prevent breakages
edf5f1b
@0xAurelius @psparacino
Port of retirement snapshots (#191)
934eba9 
* Initial port of retirement snapshots with bugs

* Try fixing MCO2 retired stat

* Increment version

* Fix minor issues

* add handleMossRetirement test

* fix generateDailyKlimeRetirement param

* remove snapshot from native retire test

* fix snapshot id

* Remove unused import

* Fix CCO2 typo

* Fix DailyKlimaRetireSnapshots units issue

* Fix typo

* Remaining MCO2 fixes

* Fix Moss test

---------

Co-authored-by: psparacino <[email protected]>
@psparacino
clean up handler
ea4cb6f
@psparacino
Update .gitignore to ignore .bin directories within tests and remove …
5310258 
…cached .bin directories
@psparacino
updated gitingore rule for tests binaries
ee06353
@0xAurelius @psparacino
Add CMARK registry to prevent breakages
8987c56
@0xAurelius @psparacino
Port of retirement snapshots (#191)
200c892 
* Initial port of retirement snapshots with bugs

* Try fixing MCO2 retired stat

* Increment version

* Fix minor issues

* add handleMossRetirement test

* fix generateDailyKlimeRetirement param

* remove snapshot from native retire test

* fix snapshot id

* Remove unused import

* Fix CCO2 typo

* Fix DailyKlimaRetireSnapshots units issue

* Fix typo

* Remaining MCO2 fixes

* Fix Moss test

---------

Co-authored-by: psparacino <[email protected]>
@psparacino
Merge remote-tracking branch 'refs/remotes/origin/pdc/clean-up-cco2-h…
daf3d59 
…andler' into pdc/clean-up-cco2-handler
@psparacino
Merge remote-tracking branch 'origin/staging' into pdc/clean-up-cco2-…
83fcdab 
…handler
@psparacino
increment package version
e510b48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xAurelius 0xAurelius 0xAurelius approved these changes

@must-be-carbon must-be-carbon Awaiting requested review from must-be-carbon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psparacino @0xAurelius